-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert cri-o freeze #1343
base: main
Are you sure you want to change the base?
Revert cri-o freeze #1343
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold /cc @enp0s3 @brianmcarey |
/retest |
so the fix should be in crun, so any cri-o version should work given the correct crun version (1.19) |
@brianmcarey I believe we're consuming crun through the cri-o install? and that does not have 1.19 yet |
ah gotcha. 1.31.1 does not have an updated crun. I am trying to figure out a bug I've introduced and once I do that i'll cut a 1.31.2 which will have new crun |
@haircommander Hi, if for example we want to consume latest CRIO with latest crun, is there DNF repo that contains nightly RPMs of latest CRIO and crun builds? |
@ormergi Hi, do you know if there was a progress since CRIO was pinned? AFAIK it were the network tests that failed to create the network tap device. |
@ormergi Sorry I've missed that @akalenyu pointed out https://issues.redhat.com/browse/OCPBUGS-45394 |
/retest |
…ubevirt#1320)" This reverts commit 6c4fa8f. Signed-off-by: Alex Kalenyuk <[email protected]>
Signed-off-by: Alex Kalenyuk <[email protected]>
6cf1c65
to
94883af
Compare
I believe you meant 1.31.4? I am looking at latest
(only in crun 1.19 according to release notes)
|
@akalenyu: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Once the cri-o issues are fixed, we should continue consuming latest cri-o.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: