-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster-up, kind, common: Enable TopologyManager for kind-sriov #1347
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
/retest-required |
Changed topology manager policy to |
SRIOV tests check topology alignemnt. Currently in kind/sriov kueblet does not attempt to align resources hence topology tests don't really validate anything of interest. Add topology manager[1] to kubelet config and set its policy to single-numa-node. Together with cpu-manager policy =static, which we already set, kubelet will reject a pod that it is unable to align. It has been tested sucesfully in a kubevirt/kubevirt PR[2] [1] https://kubernetes.io/docs/tasks/administer-cluster/topology-manager/ [2] kubevirt/kubevirt#13685 Signed-off-by: Nir Dothan <[email protected]>
/retest-required |
/test check-up-kind-sriov |
@brianmcarey @ormergi It's probably failing barbecue of #1348 |
I dont see why #1348 cuasing this PR is failing. If anything, I hope we can get #1348 merged as soon as possible in favor of returning the lane to be required. |
@nirdothan: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
SRIOV tests check topology alignemnt. Currently in kind/sriov kueblet does not attempt to align resources hence topology tests don't really validate anything of interest. Add topology manager[1] to kubelet config and set its policy to single-numa-node. Together with cpu-manager policy =static, which we already set, kubelet will reject a pod that it is unable to align. It has been tested sucesfully in a kubevirt/kubevirt PR[2] [1] https://kubernetes.io/docs/tasks/administer-cluster/topology-manager/ [2] kubevirt/kubevirt#13685
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: