Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster-up, kind, common: Enable TopologyManager for kind-sriov #1347

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nirdothan
Copy link

SRIOV tests check topology alignemnt. Currently in kind/sriov kueblet does not attempt to align resources hence topology tests don't really validate anything of interest. Add topology manager[1] to kubelet config and set its policy to single-numa-node. Together with cpu-manager policy =static, which we already set, kubelet will reject a pod that it is unable to align. It has been tested sucesfully in a kubevirt/kubevirt PR[2] [1] https://kubernetes.io/docs/tasks/administer-cluster/topology-manager/ [2] kubevirt/kubevirt#13685

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

NONE

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jan 16, 2025
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dhiller for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nirdothan
Copy link
Author

/retest-required

@nirdothan
Copy link
Author

/retest-required

@nirdothan
Copy link
Author

nirdothan commented Jan 16, 2025

Changed topology manager policy to restricted as sriov tests failed since scheduler could not allocate all resources on a single numa (I suspect)

SRIOV tests check topology alignemnt. Currently in kind/sriov kueblet does not attempt to align resources hence topology tests don't really validate anything of interest.
Add topology manager[1] to kubelet config and set its policy to single-numa-node. Together with cpu-manager policy =static, which we already set, kubelet will reject a pod that it is unable to align.
It has been tested sucesfully in a kubevirt/kubevirt PR[2]
[1] https://kubernetes.io/docs/tasks/administer-cluster/topology-manager/
[2] kubevirt/kubevirt#13685

Signed-off-by: Nir Dothan <[email protected]>
@nirdothan
Copy link
Author

/retest-required

@brianmcarey
Copy link
Member

/test check-up-kind-sriov

@nirdothan
Copy link
Author

/test check-up-kind-sriov

@brianmcarey @ormergi It's probably failing barbecue of #1348

@ormergi
Copy link
Contributor

ormergi commented Jan 20, 2025

/test check-up-kind-sriov

@brianmcarey @ormergi It's probably failing barbecue of #1348

I dont see why #1348 cuasing this PR is failing.
Looking into the last failure logs, it seems kubevirt deployment failed
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirtci/1347/check-up-kind-sriov/1879983806077734912#1:build-log.txt%3A2473

If anything, I hope we can get #1348 merged as soon as possible in favor of returning the lane to be required.

@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Jan 20, 2025

@nirdothan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
check-provision-k8s-1.31-s390x 20855e2 link true /test check-provision-k8s-1.31-s390x
check-up-kind-sriov 20855e2 link false /test check-up-kind-sriov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/enhancement size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants