Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gocli startup in s390x architecture #1354

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nestoracunablanco
Copy link

The gocli container image is multi-architecture compatible; however, it attempts to download the k8s-1.30 image, which is not available for the s390x architecture. The k8s-1.30-slim image, on the other hand, is compatible. To enable support for s390x, we can enforce the use of the --slim parameter for this architecture.

Release note:

NONE

The gocli container image is multi-architecture compatible;
however, it attempts to download the k8s-1.30 image, which is not
available for the s390x architecture. The k8s-1.30-slim image, on
the other hand, is compatible. To enable support for s390x, we can
enforce the use of the --slim parameter for this architecture.

Signed-off-by: Nestor Acuna Blanco <[email protected]>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jan 21, 2025
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign davidvossel for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@brianmcarey
Copy link
Member

/cc @chandramerla

@nestoracunablanco
Copy link
Author

/test check-provision-k8s-1.31

1 similar comment
@nestoracunablanco
Copy link
Author

/test check-provision-k8s-1.31

@kubevirt-bot
Copy link
Contributor

@nestoracunablanco: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
check-provision-k8s-1.31-s390x c7887ca link false /test check-provision-k8s-1.31-s390x
check-up-kind-sriov c7887ca link false /test check-up-kind-sriov
check-provision-k8s-1.32 c7887ca link true /test check-provision-k8s-1.32
check-provision-k8s-1.30 c7887ca link true /test check-provision-k8s-1.30
check-provision-k8s-1.31 c7887ca link true /test check-provision-k8s-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants