chore: Cleanup old manifests #1356

brianmcarey · 2025-01-22T11:00:02Z

What this PR does / why we need it:

These manifests have been copied to gocli and they are now applied from there. These manifests were a leftover and should be cleaned up.

I have included links in the commits to the new location for each of these manifests.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Design: A design document was considered and is present (link) or not required
PR: The PR description is expressive enough and will help future contributors
Code: Write code that humans can understand and Keep it simple
Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
Upgrade: Impact of this change on upgrade flows was considered and addressed if required
Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
Community: Announcement to kubevirt-dev was considered

Release note:

kubevirt-bot · 2025-01-22T11:00:04Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

brianmcarey · 2025-01-22T11:00:18Z

/test check-provision-k8s-1.31

brianmcarey · 2025-01-22T11:33:55Z

/test check-provision-k8s-1.31

brianmcarey · 2025-01-22T13:51:56Z

/test check-provision-k8s-1.31

dhiller · 2025-01-27T10:50:29Z

/cc

As these manifests have all been moved into gocli - these should no longer be needed https://github.com/kubevirt/kubevirtci/tree/0ac92163592c88bfba23cbf5d0c525fd6cc57c23/cluster-provision/gocli/opts/prometheus/manifests Signed-off-by: Brian Carey <[email protected]>

These manifest have been moved to gocli https://github.com/kubevirt/kubevirtci/tree/0ac92163592c88bfba23cbf5d0c525fd6cc57c23/cluster-provision/gocli/opts/nfscsi Signed-off-by: Brian Carey <[email protected]>

These manifests have been moved to gocli https://github.com/kubevirt/kubevirtci/tree/0ac92163592c88bfba23cbf5d0c525fd6cc57c23/cluster-provision/gocli/opts/multus/manifests Signed-off-by: Brian Carey <[email protected]>

These manifests have been moved to gocli - https://github.com/kubevirt/kubevirtci/tree/0ac92163592c88bfba23cbf5d0c525fd6cc57c23/cluster-provision/gocli/opts/aaq/manifests Signed-off-by: Brian Carey <[email protected]>

These manifests have been moved to gocli - https://github.com/kubevirt/kubevirtci/tree/0ac92163592c88bfba23cbf5d0c525fd6cc57c23/cluster-provision/gocli/opts/cdi/manifests Signed-off-by: Brian Carey <[email protected]>

These manifest have been moved to gocli - https://github.com/kubevirt/kubevirtci/tree/0ac92163592c88bfba23cbf5d0c525fd6cc57c23/cluster-provision/gocli/opts/rookceph/manifests Signed-off-by: Brian Carey <[email protected]>

These manifests have been moved to gocli - https://github.com/kubevirt/kubevirtci/tree/0ac92163592c88bfba23cbf5d0c525fd6cc57c23/cluster-provision/gocli/opts/cnao/manifests Signed-off-by: Brian Carey <[email protected]>

Signed-off-by: Brian Carey <[email protected]>

…resent on node Signed-off-by: Brian Carey <[email protected]>

Signed-off-by: Brian Carey <[email protected]>

brianmcarey · 2025-01-28T14:37:36Z

@dhiller rebased and should be ready for review.

kubevirt-bot · 2025-01-28T18:35:03Z

@brianmcarey: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
check-provision-k8s-1.31-s390x	`6713bbb`	link	false	`/test check-provision-k8s-1.31-s390x`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

dhiller · 2025-01-29T09:54:52Z

cluster-provision/k8s/1.32/k8s_provision.sh

-cp -rf /tmp/cdi*.yaml /opt/
-
-# copy aaq manifests
-cp -rf /tmp/aaq/ /opt/


In the check-provision I don't see the aaq deployed, at least the flag is set to false. Is that tested somewhere else?

@Barakmor1 do you know? Maybe we can check that part by just enabling the flag on the provision-check or is there something that speaks against this?

dhiller

/approve

@Barakmor1 if it's worth it we should make sure we test the aaq deployment somehow

kubevirt-bot · 2025-01-29T11:10:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dhiller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Barakmor1 · 2025-01-29T12:04:15Z

/hold

Barakmor1 · 2025-01-29T12:04:44Z

@brianmcarey @dhiller Please give me a chance to have a look

Barakmor1 · 2025-01-29T12:10:56Z

Honestly, I think this was merged too fast. I didn't have enough time to review, but the AAQ deployment was useful for manual testing.

[02ffdf4 chore: Cleanup old manifests](kubevirt/kubevirtci#1356) [a1574f9 nfs-csi: Increase timeout for pvc to reach bound state](kubevirt/kubevirtci#1359) [3da6ba3 provision: Clean up old images from extra-pre-pull-images](kubevirt/kubevirtci#1357) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>

[36f1f62 Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1360) [02ffdf4 chore: Cleanup old manifests](kubevirt/kubevirtci#1356) [a1574f9 nfs-csi: Increase timeout for pvc to reach bound state](kubevirt/kubevirtci#1359) [3da6ba3 provision: Clean up old images from extra-pre-pull-images](kubevirt/kubevirtci#1357) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>

kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 22, 2025

kubevirt-bot added the size/XXL label Jan 22, 2025

brianmcarey mentioned this pull request Jan 23, 2025

provision: Clean up old images from extra-pre-pull-images #1357

Merged

8 tasks

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 25, 2025

kubevirt-bot requested a review from dhiller January 27, 2025 10:50

brianmcarey added 10 commits January 28, 2025 08:24

chore: Cleanup old nfs-csi manifests as no longer needed

3562a0d

These manifest have been moved to gocli https://github.com/kubevirt/kubevirtci/tree/0ac92163592c88bfba23cbf5d0c525fd6cc57c23/cluster-provision/gocli/opts/nfscsi Signed-off-by: Brian Carey <[email protected]>

chore: Cleanup old multus manifests as no longer needed

70c2f83

These manifests have been moved to gocli https://github.com/kubevirt/kubevirtci/tree/0ac92163592c88bfba23cbf5d0c525fd6cc57c23/cluster-provision/gocli/opts/multus/manifests Signed-off-by: Brian Carey <[email protected]>

chore: Remove old aaq manifests that are not needed

9a8f0ef

These manifests have been moved to gocli - https://github.com/kubevirt/kubevirtci/tree/0ac92163592c88bfba23cbf5d0c525fd6cc57c23/cluster-provision/gocli/opts/aaq/manifests Signed-off-by: Brian Carey <[email protected]>

chore: Remove old CDI manifests as no longer needed

07c01db

These manifests have been moved to gocli - https://github.com/kubevirt/kubevirtci/tree/0ac92163592c88bfba23cbf5d0c525fd6cc57c23/cluster-provision/gocli/opts/cdi/manifests Signed-off-by: Brian Carey <[email protected]>

chore: Remove old ceph manifests that are no longer needed

0e76c60

These manifest have been moved to gocli - https://github.com/kubevirt/kubevirtci/tree/0ac92163592c88bfba23cbf5d0c525fd6cc57c23/cluster-provision/gocli/opts/rookceph/manifests Signed-off-by: Brian Carey <[email protected]>

centos: Update base image as manifests are copied there

a7925df

Signed-off-by: Brian Carey <[email protected]>

provision: Remove kustomize of grafana manifests that are no longer p…

66a6703

…resent on node Signed-off-by: Brian Carey <[email protected]>

provision: Remove copy of manifests that are no longer on the node

6713bbb

Signed-off-by: Brian Carey <[email protected]>

brianmcarey force-pushed the cleanup-old-manifests branch from d84be2f to 6713bbb Compare January 28, 2025 08:25

kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2025

brianmcarey marked this pull request as ready for review January 28, 2025 14:37

kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 28, 2025

dosubot bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 28, 2025

kubevirt-bot requested a review from ormergi January 28, 2025 14:37

kubevirt-bot requested a review from qinqon January 28, 2025 14:37

dhiller reviewed Jan 29, 2025

View reviewed changes

dhiller approved these changes Jan 29, 2025

View reviewed changes

kubevirt-bot assigned dhiller Jan 29, 2025

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2025

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2025

kubevirt-bot merged commit 02ffdf4 into kubevirt:main Jan 29, 2025
10 of 11 checks passed

kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2025

kubevirt-bot mentioned this pull request Jan 29, 2025

Bump kubevirtci kubevirt/kubevirt#13818

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Cleanup old manifests #1356

chore: Cleanup old manifests #1356

brianmcarey commented Jan 22, 2025 •

edited

Loading

kubevirt-bot commented Jan 22, 2025

brianmcarey commented Jan 22, 2025

brianmcarey commented Jan 22, 2025

brianmcarey commented Jan 22, 2025

dhiller commented Jan 27, 2025

brianmcarey commented Jan 28, 2025

kubevirt-bot commented Jan 28, 2025 •

edited

Loading

dhiller Jan 29, 2025

dhiller Jan 29, 2025

dhiller left a comment

kubevirt-bot commented Jan 29, 2025

Barakmor1 commented Jan 29, 2025

Barakmor1 commented Jan 29, 2025

Barakmor1 commented Jan 29, 2025

chore: Cleanup old manifests #1356

chore: Cleanup old manifests #1356

Conversation

brianmcarey commented Jan 22, 2025 • edited Loading

kubevirt-bot commented Jan 22, 2025

brianmcarey commented Jan 22, 2025

brianmcarey commented Jan 22, 2025

brianmcarey commented Jan 22, 2025

dhiller commented Jan 27, 2025

brianmcarey commented Jan 28, 2025

kubevirt-bot commented Jan 28, 2025 • edited Loading

dhiller Jan 29, 2025

Choose a reason for hiding this comment

dhiller Jan 29, 2025

Choose a reason for hiding this comment

dhiller left a comment

Choose a reason for hiding this comment

kubevirt-bot commented Jan 29, 2025

Barakmor1 commented Jan 29, 2025

Barakmor1 commented Jan 29, 2025

Barakmor1 commented Jan 29, 2025

brianmcarey commented Jan 22, 2025 •

edited

Loading

kubevirt-bot commented Jan 28, 2025 •

edited

Loading