Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add newline to commit msg for bump prow jobs (#2466)" #2474

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

brianmcarey
Copy link
Member

This reverts commit 8fe7566.

The newline character did not result in a new line in the PR description so it did not have the desired effect[1]. Revert back to previous commit message.

/cc @dhiller

[1] #2472 (comment)

@kubevirt-bot kubevirt-bot requested a review from dhiller November 21, 2022 08:21
@kubevirt-bot kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. size/XS labels Nov 21, 2022
This reverts commit 8fe7566.

The newline character did not result in a new line in the PR description
so it did not have the desired effect. Revert back to previous commit
message.

Signed-off-by: Brian Carey <[email protected]>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Nov 21, 2022
Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

I was thinking a bit about this. I saw two options:

  • make this a command line option, i.e. -C @kubevirtci-taskforce
  • use a special env var for the text (so you can use multiple lines) that you then set in the job config

Both options would require adjustments inside the script and the jobconfig. Not sure what would be the best here. I'd lean towards the command line option since it's more explicit.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2022
@kubevirt-bot kubevirt-bot merged commit c3f8b1f into kubevirt:main Nov 21, 2022
@kubevirt-bot
Copy link
Contributor

@brianmcarey: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

  • key project-infra-periodics.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/project-infra/project-infra-periodics.yaml

In response to this:

This reverts commit 8fe7566.

The newline character did not result in a new line in the PR description so it did not have the desired effect[1]. Revert back to previous commit message.

/cc @dhiller

[1] #2472 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants