-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
needs-approver-review: enable management by GH team #3770
Merged
kubevirt-bot
merged 1 commit into
kubevirt:main
from
dhiller:add-approver-review-gh-group-for-label-management
Nov 25, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to add the
needs-approver-review-labellabel to thekubevirtkubevirt-labelgroup below instead of creating a new one?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, since this group can change the label in every repo, whereas the other group can only change labels inside k/kubevirt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for it though?
Why wouldn't members be able to add the
good-first-issueto every repo?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In any case, it shouldn't block this PR, just an idea.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because at the time there was opinions about how and when to apply the labels good-first-issue and help-wanted and who could apply them.
I.e. for project-infra it works through the prow help plugin - anyone can just write
/help-wantedor/good-first-issueand the labels will get applied. In contrast to this in k/kubevirt the consensus was that only a dedicated group of people should apply labels (that's also the reason why there's twogood-first-issuelabels (https://github.com/kubevirt/project-infra/blob/main/docs/labels.md#good%20first%20issue).As much as I had wanted to align people over just using the prow help plugin and not having to maintain an extra configuration for labels, we didn't agree on this - and I respect that decision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example issue for k/project-infra: #3768 (comment)
(reaction by plugin can be seen in follow up)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^^ @iholder101
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot one thing: the help plugin has the drawback that everyone who comments on a PR can apply the label - I think the label should only get applied if an org member does comment, however I don't know that for sure and would need to check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just checked - the plugin reacts to any comment, so in essence anyone with a GitHub account can trigger help, however I think the cost of unjustified application of a label is neglectible to the cost of having to maintain the configuration, but that's just my opinion.