Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prow jobs for publishing centos9 multi arch image #3788

Merged

Conversation

chandramerla
Copy link
Contributor

What this PR does / why we need it:
This PR adds multi-arch publish jobs for centos9 images.
As we've added s390x support in k8s provider (started with 1.30 slim), centos9 and gocli images as part of kubevirt/kubevirtci#1252, this PR does changes required in project-infra repo to enable the prow jobs for publishing centos9 multi-arch image.

There is another PR where publishing of multi-arch images of k8s provider is handled: #3566

Special notes for your reviewer:
/cc @brianmcarey

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

NONE

…s base for s390x and manifest-list

Also modified periodic-kubevirtci-bump-centos-base (x86 job) to signal and pass KUBEVIRTCI_TAG to s390x job

Signed-off-by: chandramerla <[email protected]>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M labels Nov 27, 2024
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

thanks a lot for this @chandramerla

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2024
@kubevirt-bot kubevirt-bot merged commit 7240ba6 into kubevirt:main Nov 27, 2024
5 checks passed
@kubevirt-bot
Copy link
Contributor

@chandramerla: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

  • key kubevirtci-periodics.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-periodics.yaml

In response to this:

What this PR does / why we need it:
This PR adds multi-arch publish jobs for centos9 images.
As we've added s390x support in k8s provider (started with 1.30 slim), centos9 and gocli images as part of kubevirt/kubevirtci#1252, this PR does changes required in project-infra repo to enable the prow jobs for publishing centos9 multi-arch image.

There is another PR where publishing of multi-arch images of k8s provider is handled: #3566

Special notes for your reviewer:
/cc @brianmcarey

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants