-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community: add test, lint and coverage jobs #3824
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Based on PR kubevirt/community#368 where new make targets test, lint and coverage are introduced we are adding new presubmit jobs that execute them. Signed-off-by: Daniel Hiller <[email protected]>
838b994
to
ed06551
Compare
/cc @EdDev for wg-code-quality |
@aburdenthehand: GitHub didn't allow me to request PR reviews from the following users: for. Note that only kubevirt members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-project-infra-lint |
@dhiller: The
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-project-infra-lint |
/cc |
What this PR does / why we need it:
Based on PR kubevirt/community#368 where new make targets test and lint are introduced we are adding new presubmit jobs that execute them.
/hold to wait for above PR to land
/wg code-quality
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer: