chore: remove ginkgo install #3905
Conversation
install of ginkgo binary can be removed as the dependency is used directly. Signed-off-by: Daniel Hiller <[email protected]>
|
Skipping CI for Draft Pull Request. |
kubevirt-bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/rehearse ? |
|
Rehearsal is available for the following jobs in this PR: You can trigger rehearsal for all jobs by commenting either For a specific PR you can comment For a list of jobs that you can rehearse you can comment |
|
/rehearse pull-project-infra-coverage |
|
Rehearsal jobs created for this PR: You can trigger rehearsal for all jobs by commenting either For a specific PR you can comment For a list of jobs that you can rehearse you can comment |
|
/rehearse pull-project-infra-coverage |
|
Rehearsal jobs created for this PR: You can trigger rehearsal for all jobs by commenting either For a specific PR you can comment For a list of jobs that you can rehearse you can comment |
this in order to align to other test jobs, as it seems the process starves regularly. Compare run times of https://prow.ci.kubevirt.io/job-history/gs/kubevirt-prow/pr-logs/directory/pull-project-infra-coverage vs. https://prow.ci.kubevirt.io/job-history/gs/kubevirt-prow/pr-logs/directory/pull-project-infra-test-robots Signed-off-by: Daniel Hiller <[email protected]>
dhiller
force-pushed
the
remove-ginkgo-install
branch
from
1ef0dc7 to
8bb3ace
Compare
|
/rehearse |
|
Rehearsal jobs created for this PR: You can trigger rehearsal for all jobs by commenting either For a specific PR you can comment For a list of jobs that you can rehearse you can comment |
|
Successful rehearsal of coverage here: https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/3905/rehearsal-pull-project-infra-coverage/1881665111219769344 |
kubevirt-bot
removed
the
do-not-merge/work-in-progress
update build process to other image builds Signed-off-by: Daniel Hiller <[email protected]>
What this PR does / why we need it:
install of ginkgo binary is removed as the dependency is used directly now.
Also memory requests and limits are increased since it seems the job suffers from starvation sometimes: https://prow.ci.kubevirt.io/job-history/gs/kubevirt-prow/pr-logs/directory/pull-project-infra-coverage
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer: