Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mTLS support #1000

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

fabriziosestito
Copy link
Contributor

@fabriziosestito fabriziosestito commented Feb 6, 2025

Description

This PR introduces the --client-ca-config-map flag.
When specified, the setup function configures the webhook server with the client CA.
Additionally, it mounts the ConfigMap in the reconciled PolicyServer deployments and sets the KUBEWARDEN_CLIENT_CA_FILE environment variable to the CA path.

Fix: #993

@fabriziosestito fabriziosestito force-pushed the feat/add-mtls branch 4 times, most recently from 8eb2545 to c50e9f1 Compare February 6, 2025 16:44
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.35%. Comparing base (3568e7c) to head (106cca1).

❗ There is a different number of reports uploaded between BASE (3568e7c) and HEAD (106cca1). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3568e7c) HEAD (106cca1)
integration-tests 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1000       +/-   ##
===========================================
- Coverage   72.43%   59.35%   -13.09%     
===========================================
  Files          30       17       -13     
  Lines        3661     1545     -2116     
===========================================
- Hits         2652      917     -1735     
+ Misses        854      617      -237     
+ Partials      155       11      -144     
Flag Coverage Δ
integration-tests ?
unit-tests 59.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabriziosestito fabriziosestito changed the title Feat/add mtls feat: add mTLS support Feb 6, 2025
@fabriziosestito fabriziosestito marked this pull request as ready for review February 7, 2025 15:21
@fabriziosestito fabriziosestito requested a review from a team as a code owner February 7, 2025 15:21
@fabriziosestito fabriziosestito self-assigned this Feb 7, 2025
@fabriziosestito fabriziosestito added this to the 1.22 milestone Feb 7, 2025
Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it!

…e client certificate if specified

Signed-off-by: Fabrizio Sestito <[email protected]>
…y server to enable mTLS

Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
Copy link
Member

@viccuad viccuad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Pending review
Development

Successfully merging this pull request may close these issues.

Add mTLS support
4 participants