feat: full implementation of AdmissionResponse object #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement all the fields that are part of an AdmissionResponse object. While doing that I also cleaned up a bit our code. I've turned some `String` into `enums` and I've added some inline documentation by doing copy and paste from the Kubernetes' one. Note: we cannot rely on `k8s-openapi` for these Rust structs since they are not part of the OpenAPI definitions of Kubernetes. Signed-off-by: Flavio Castelli <[email protected]>
fabriziosestito
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement all the fields that are part of an AdmissionResponse object.
While doing that I also cleaned up a bit our code. I've turned some
Stringintoenumsand I've added some inline documentation by doing copy and paste from the Kubernetes' one.Note: we cannot rely on
k8s-openapifor these Rust structs since they are not part of the OpenAPI definitions of Kubernetes.