standardize binder cache store #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuey002
requested review from
XinyiSong,
Liumeng-lambert and
NickrenREN
as code owners
yuey002
force-pushed
the
dev/migrate-binder-cache
branch
6 times, most recently
from
19266f2 to
fb148e5
Compare
yuey002
changed the title
binacs
reviewed
Jun 10, 2024
| @@ -260,6 +268,8 @@ func (binder *Binder) CheckAndBindUnit(ctx context.Context) bool { | |||
| klog.InfoS("Failed to check stage for unit", "stageIndex", i, "stageName", stage.stageName, "unitKey", unit.GetKey(), "err", err) | |||
| } | |||
|
|
|||
| klog.V(4).InfoS("Finish to check stage for unit", "stageIndex", i, "stageName", stage.stageName, "unitKey", unit.GetKey()) | |||
|
lgtm overall, just nits |
yuey002
force-pushed
the
dev/migrate-binder-cache
branch
from
fb148e5 to
bcf1995
Compare
|
@lzlaa Could you also help take a look at this PR when getting a chance? Thank you. |
binacs
previously approved these changes
Jun 10, 2024
lzlaa
reviewed
Jun 13, 2024
|
|
||
| // TODO: Extend the metrics related. | ||
| // updateMetrics updates cache size metric values for pods, assumed pods, and nodes | ||
| func (cache *binderCache) updateMetrics() { | ||
| cache.mu.Lock() |
There was a problem hiding this comment.
Just RLock、RUnlock is ok，since there no update operation for PodStore or NodeStore
There was a problem hiding this comment.
There's only read operation for PodStore or NodeStore; however, there's update on binder cache size. If we use read lock, multiple threads can call updateMetrics() and modify the only binder cache size. Thoughts?
There was a problem hiding this comment.
I also prefer to keep the use of write lock.
yuey002
force-pushed
the
dev/migrate-binder-cache
branch
from
bcf1995 to
1ce06bb
Compare
lzlaa
approved these changes
Jun 17, 2024
binacs
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fist half of the second step of #45
Standardize binder cache implementation based on the common store interface.