dev/echo/support rescheduling #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XinyiSong
requested review from
zryfish,
lzlaa,
Liumeng-lambert,
binacs,
yuey002,
lintongj and
NickrenREN
as code owners
|
|
XinyiSong
force-pushed
the
dev/echo/support-rescheduling
branch
from
cc5cbea to
5d01f0f
Compare
XinyiSong
force-pushed
the
dev/echo/support-rescheduling
branch
3 times, most recently
from
99dfdaa to
60615aa
Compare
binacs
reviewed
Jul 23, 2024
pkg/framework/api/common_state.go
Outdated
|
|
||
| NotScheduledPodKeysByTemplateKey = "NotScheduledPodKeysByTemplate" | ||
|
|
||
| PostNodeCircleSchedulingFuncKey = "PostNodeCircleSchedulingFunc" |
There was a problem hiding this comment.
nit: this is a temporary solution (for metrics) and should not be migrated to the open source repo
pkg/framework/api/movement_test.go
Outdated
|
|
||
| schedulingv1a1 "github.com/kubewharf/godel-scheduler-api/pkg/apis/scheduling/v1alpha1" | ||
| "github.com/kubewharf/godel-scheduler/pkg/util/generationstore" | ||
| podutil "github.com/kubewharf/godel-scheduler/pkg/util/pod" |
There was a problem hiding this comment.
nit: format this (separate from k8s pkg)
rookie0080
reviewed
Jul 26, 2024
pkg/framework/api/common_state.go
Outdated
| return nil, fmt.Errorf("post nodeCircle scheduling func not found") | ||
| } | ||
|
|
||
| func RunPostNodeCircleSchedulingFunc(unitState *CycleState, nodeCircle NodeCircle, pod *v1.Pod, suggesstHost string, err error) { |
There was a problem hiding this comment.
The parameter err here will be overwritten in the if block, And it has been fixed in the latest version
XinyiSong
force-pushed
the
dev/echo/support-rescheduling
branch
2 times, most recently
from
4c006fb to
3aa0129
Compare
XinyiSong
force-pushed
the
dev/echo/support-rescheduling
branch
from
3aa0129 to
0fad9e8
Compare
rookie0080
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.