-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement(plugin): Support inter-pod affinity and anti-affinity at NUMA level #347
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
==========================================
+ Coverage 53.79% 54.14% +0.34%
==========================================
Files 446 452 +6
Lines 49420 50464 +1044
==========================================
+ Hits 26587 27322 +735
- Misses 19816 20078 +262
- Partials 3017 3064 +47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c99afb3
to
b9524f2
Compare
b9524f2
to
c2cc0ee
Compare
pkg/scheduler/cache/nodeinfo.go
Outdated
func (n *NodeInfo) GetAssumedPodAffinityInfo() AssumedPodAffinityInfo { | ||
n.Mutex.RLock() | ||
defer n.Mutex.RUnlock() | ||
return n.AssumedPodAffinityInfo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AssumedPodAffinityInfo is not thread safe, maybe it is better to return a deepcopy ?
c2cc0ee
to
0da227a
Compare
32a56da
to
94e8d09
Compare
b5324f3
to
394e087
Compare
bf5463b
to
4b6dcdd
Compare
What type of PR is this?
Enhancement
What this PR does / why we need it:
Support inter-pod affinity and anti-affinity at NUMA level,#220