Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(qrm): add nic selection result annotation #767

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

luomingmeng
Copy link
Collaborator

@luomingmeng luomingmeng commented Jan 16, 2025

What type of PR is this?

Features

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng force-pushed the dev/add-nic-selection-result-annotation branch from 3073765 to cf07b6d Compare January 16, 2025 13:20
@luomingmeng luomingmeng self-assigned this Jan 16, 2025
@luomingmeng luomingmeng changed the title add nic selection result annotation feat(qrm): add nic selection result annotation Jan 16, 2025
@luomingmeng luomingmeng force-pushed the dev/add-nic-selection-result-annotation branch 2 times, most recently from 8f256d4 to 6f74065 Compare January 17, 2025 02:40
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 53.57143% with 65 lines in your changes missing coverage. Please review.

Project coverage is 60.49%. Comparing base (0c24ce6) to head (683ae8b).

Files with missing lines Patch % Lines
pkg/agent/qrm-plugins/commonstate/state.go 27.27% 16 Missing ⚠️
...qrm-plugins/util/reactor/pod_allocation_reactor.go 50.00% 10 Missing and 5 partials ⚠️
...ork/staticpolicy/reactor/nic_allocation_reactor.go 62.85% 9 Missing and 4 partials ⚠️
...y/dynamicpolicy/reactor/numa_allocation_reactor.go 57.14% 6 Missing and 3 partials ⚠️
...g/agent/qrm-plugins/memory/dynamicpolicy/policy.go 0.00% 5 Missing and 1 partial ⚠️
...g/agent/qrm-plugins/network/staticpolicy/policy.go 80.00% 3 Missing and 1 partial ⚠️
...d/katalyst-agent/app/options/qrm/network_plugin.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #767      +/-   ##
==========================================
- Coverage   60.69%   60.49%   -0.21%     
==========================================
  Files         603      605       +2     
  Lines       63212    63287      +75     
==========================================
- Hits        38367    38284      -83     
- Misses      21002    21149     +147     
- Partials     3843     3854      +11     
Flag Coverage Δ
unittest 60.49% <53.57%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luomingmeng luomingmeng force-pushed the dev/add-nic-selection-result-annotation branch 2 times, most recently from 6883b5d to 71ecc19 Compare January 17, 2025 09:11
@luomingmeng luomingmeng force-pushed the dev/add-nic-selection-result-annotation branch from 71ecc19 to 683ae8b Compare January 17, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant