Patches #181

kkappler · 2023-12-27T21:34:29Z

No description provided.

- replace initialization of calibrated_ts in remove_instrument_response with a dataless copy rather than dict-based method (see issue #180 for notes)

- fix bug in ts_filters.RemoveInstrumentResponse.apply_bandpass - was passing sample_interval when sample_rate was expected - tidy doc and nomenclature - catch exceptions - add descriptive logging for bandpass filter

- include example of bandpass filter - rename vars as hx instead of ex as this is a magnetic example

codecov-commenter · 2023-12-27T21:36:31Z

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (79828c5) 59.53% compared to head (505d8dc) 59.81%.

Files	Patch %	Lines
mth5/timeseries/ts_filters.py	80.00%	5 Missing ⚠️
mth5/timeseries/channel_ts.py	50.00%	1 Missing ⚠️
tests/timeseries/test_ts_filters.py	98.14%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
+ Coverage   59.53%   59.81%   +0.27%     
==========================================
  Files         138      139       +1     
  Lines       15244    15322      +78     
==========================================
+ Hits         9076     9165      +89     
+ Misses       6168     6157      -11

Flag	Coverage Δ
tests	`59.81% <92.13%> (+0.27%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- this allows for a more correct use of context manager - this addresses the issues noted in issue #184

Add return self to open_mth5()

kujaku11

Good changes, looks ready to merge.

kkappler added 4 commits December 27, 2023 13:25

Address isssue #180

e2ded2d

- replace initialization of calibrated_ts in remove_instrument_response with a dataless copy rather than dict-based method (see issue #180 for notes)

bug fix

a6199c4

- fix bug in ts_filters.RemoveInstrumentResponse.apply_bandpass - was passing sample_interval when sample_rate was expected - tidy doc and nomenclature - catch exceptions - add descriptive logging for bandpass filter

change bandpass message level to info from warning

ccb863b

update notebook

ee2c14b

- include example of bandpass filter - rename vars as hx instead of ex as this is a magnetic example

kkappler and others added 7 commits December 28, 2023 13:42

handle request for bandpass with [None, None]

15df27c

add test

63ddc4a

add a default filter order to apply_bandpass

1c8bd1f

Add return self to open_mth5()

25d4351

- this allows for a more correct use of context manager - this addresses the issues noted in issue #184

Add a test for the other context manager syntax

1acdbc4

cruft removal

15660ef

Merge pull request #183 from kujaku11/fix_issue_184

505d8dc

Add return self to open_mth5()

kujaku11 approved these changes Jan 5, 2024

View reviewed changes

kujaku11 merged commit 691c73f into master Jan 5, 2024
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Patches #181

Patches #181

kkappler commented Dec 27, 2023

codecov-commenter commented Dec 27, 2023 •

edited

Loading

kujaku11 left a comment

Patches #181

Patches #181

Conversation

kkappler commented Dec 27, 2023

codecov-commenter commented Dec 27, 2023 • edited Loading

Codecov Report

kujaku11 left a comment

Choose a reason for hiding this comment

codecov-commenter commented Dec 27, 2023 •

edited

Loading