Updating bugs and Adding functionality #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- AttributeError: `np.float_` was removed in the NumPy 2.0 release. Use `np.float64` instead. - also, add %%time back into ipynb, this was not an issue
- Is it possible that github is using common storage for the tests? - I'm getting what look like synchronous access errors maybe related to multiple processes trying to access same hdf5? - KeyError: "Unable to synchronously open object (object 'channel_summary' doesn't exist)"
replace np.complex_ with np.complex128 per https://numpy.org/doc/stable/release/2.0.0-notes.html
- while working on issue #219, using the syntethic examples for some snippets, the way survey was hokey - now it is less hokey
- working with v0.1.0 files, updating survey metadata was triggering setting of stations df - this df may be empty - added a check for len(df) before trying to assign start/end
- working with v0.1.0 files, updating survey metadata was triggering operations on stations df - this df may be empty - added a check for len(df) before trying to assign metadata from df
- also comment out an assert that fails for files with no survey name - added a TODO for that
- these tests actually relate to #209 - added some doc as well
Fix issue 219
- a sort of continuation of issue #209, but a new fork from patches as that branch is already merged - add MultivariateLabelScheme() class to manage how we label multivariate channels - add MultivariateDataset() class to wrap the MV xarray - add some tests - tests could be better organized if address issue #227
kkappler
reviewed
Aug 10, 2024
There was a problem hiding this comment.
NIT: These changes do expand the tests, but a better test_fcs could be built -- one that tests acts a validator for an already built mth5 -- There are also some repeated numeric values that could be made into a fixture or helper class such that they are only declared once (e.g. expected_sr_decimation_level = 0.015380859375)
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #226 +/- ##
==========================================
+ Coverage 61.28% 61.65% +0.37%
==========================================
Files 145 149 +4
Lines 16124 16411 +287
==========================================
+ Hits 9882 10119 +237
- Misses 6242 6292 +50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kkappler
reviewed
Aug 10, 2024
There was a problem hiding this comment.
added some doc strings here
kkappler
approved these changes
Aug 10, 2024
Add some more multivariate functionality There may be some more methods needed for issue #209, but these tools seem to do most of what is needed, and tests are passing so merging into `patches`.
Fix issue 209a
- added a try/except - if exception encountered, message telling user what FCs are there, and suggesting to add the requested group - added a test for the exception
Minor multivariate updates Probably should have pushed this direct to patches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues #217, #219, #223, #220
Add functionality and minor bug fixes