Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeseries/spectre (Fix issue 269) #270

Merged
merged 35 commits into from
Jan 3, 2025
Merged

timeseries/spectre (Fix issue 269) #270

merged 35 commits into from
Jan 3, 2025

Conversation

kkappler
Copy link
Collaborator

@kkappler kkappler commented Dec 18, 2024

  • migrates the multivariate tools that had been stashed in mth5/utils/ during initial development to timeseries/spectre.
  • Renamed this module from fc_tools.py to multiple_station.py
  • brings the Spectrogam class from aurora into mth5 (this is a fairly general class that can be used to wrangle FCs, and should not be aurora-specific)
  • update imports accordingly

@kujaku11 the PR to bring this into features is an FYI to clarify these changes from what is already in patches. When you approve please consider merging patches into main as well to allow aurora to import these methods from mth5 moving forward.

@kkappler kkappler marked this pull request as ready for review December 18, 2024 19:03
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 54.73684% with 43 lines in your changes missing coverage. Please review.

Project coverage is 62.47%. Comparing base (113f1b0) to head (2c131cc).

Files with missing lines Patch % Lines
mth5/timeseries/spectre/spectrogram.py 33.87% 41 Missing ⚠️
mth5/timeseries/spectre/multiple_station.py 80.00% 1 Missing ⚠️
tests/timeseries/spectre/test_spectrogram.py 93.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           patches     #270      +/-   ##
===========================================
- Coverage    62.54%   62.47%   -0.07%     
===========================================
  Files          164      167       +3     
  Lines        17523    17606      +83     
===========================================
+ Hits         10959    11000      +41     
- Misses        6564     6606      +42     
Flag Coverage Δ
tests 62.47% <54.73%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kujaku11 kujaku11 changed the base branch from patches to features January 3, 2025 23:20
@kujaku11 kujaku11 merged commit 5101e99 into features Jan 3, 2025
8 checks passed
@kujaku11 kujaku11 deleted the fix_issue_269 branch January 3, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants