-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features #276
Open
kujaku11
wants to merge
91
commits into
patches
Choose a base branch
from
features
base: patches
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update test imports
- update tests to pass
- add some tests
Cursor 001
- also add some AI generated typehints
- generally working towards the ability to reuse the tools in make_mth5_from_ascii to make more general mth5. - the way things were set up were completely dependent on using data from the legacy EMTF ascii files - I have tried to make a SyntheticRun object be able to optionally store a dataframe in place, and only load the legacy file if there is not a dataframe present - also improve docstrings and typehinting
- some tidying and doc
- factor method to get target folder out of create_mth5_synthetic_file - remove unused import
- generate some cross powers - store them as features - close the h5 - open the h5 - read the features - assert equal to the originally computed values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding ability to include FC features.
Nice to haves include: