-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(gha): improve CodeQL #12513
base: master
Are you sure you want to change the base?
ci(gha): improve CodeQL #12513
Conversation
Signed-off-by: Bart Smykla <[email protected]>
Signed-off-by: Bart Smykla <[email protected]>
Reviewer Checklist🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
|
@@ -60,8 +64,20 @@ jobs: | |||
key: ${{ runner.os }}-${{ runner.arch }}-devtools-${{ hashFiles('mk/dependencies/deps.lock') }} | |||
restore-keys: | | |||
${{ runner.os }}-${{ runner.arch }}-devtools | |||
- name: Initialize CodeQL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be in check instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The most time takes the build step which here is already done. If we'll put it in check
we'll have to build binaries there as well which will take 10+ more minutes
Currently it's not reviewable as it's only for tests