-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kds): add support for kuma.io/kds-sync label #13008
Open
lahabana
wants to merge
5
commits into
kumahq:release-2.10
Choose a base branch
from
lahabana:kdsLabel
base: release-2.10
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer Checklist🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
|
lukidzi
reviewed
Mar 4, 2025
lukidzi
previously approved these changes
Mar 4, 2025
This allows disabling KDS for specific resources by adding the label `kuma.io/kds-sync: disabled` Fix kumahq#12916 Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Charly Molter <[email protected]>
lukidzi
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There may be cases where either system or user may want to not sync a specific resource with KDS.
Until now this wasn't really possible. So we ended having specific hard coded config types.
This allows disabling KDS for specific resources by adding the label
kuma.io/kds-sync: disabled
Implementation information
We add the filter as a check in both filters.
Also added functional testing around the whole KDS.
You can create a set of files of starting state and save end state.
This should make it easy to add a batch of non regression and exploratory tests to KDS.
Supporting documentation
Fix #12916