Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kds): add support for kuma.io/kds-sync label #13008

Open
wants to merge 5 commits into
base: release-2.10
Choose a base branch
from

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Mar 4, 2025

Motivation

There may be cases where either system or user may want to not sync a specific resource with KDS.
Until now this wasn't really possible. So we ended having specific hard coded config types.

This allows disabling KDS for specific resources by adding the label kuma.io/kds-sync: disabled

Implementation information

We add the filter as a check in both filters.
Also added functional testing around the whole KDS.
You can create a set of files of starting state and save end state.
This should make it easy to add a batch of non regression and exploratory tests to KDS.

Supporting documentation

Fix #12916

@lahabana lahabana requested a review from a team as a code owner March 4, 2025 14:33
@lahabana lahabana requested review from lobkovilya and lukidzi March 4, 2025 14:33
Copy link
Contributor

github-actions bot commented Mar 4, 2025

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

lukidzi
lukidzi previously approved these changes Mar 4, 2025
lahabana added 2 commits March 5, 2025 09:45
This allows disabling KDS for specific resources by adding the label
`kuma.io/kds-sync: disabled`

Fix kumahq#12916

Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Charly Molter <[email protected]>
lahabana added 3 commits March 5, 2025 11:00
Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana changed the base branch from master to release-2.10 March 5, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create label to disable KDS sync
2 participants