Add s390x support update #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Tools#1731) * feat: add support for forcing build metadata * Chore: Added snapshot forceBuildMetadata flag tests.
…1741) The Makefile from the `docker-credential-gcr` repo was removed, so all builds were failing. This PR removes the `make` command and pins `docker-credential-gcr` to a specific commit so that this doesn't happen again.
* chore: add workflows for pr tests * fix unit tests * fix formatting * chore: fix gobuild * change minikube script * chore: fix lint install script * chore: ignore and fix tests * fix lint and run gofmt * lint fixes * k8s executor image only * fix Makefile * fix travis env variables * more info on k8s tests * fix travis run * fix * fix * fix * fix log * some more changes * increase timeout * delete travis.yml and fix multiple copy tests * fix registry mirror * fix lint * add concurency * last attemot to fix k8 integrations * diff id for diff workflows
…Tools#1735) * chore: add workflows for pr tests * fix unit tests * fix formatting * chore: fix gobuild * change minikube script * chore: fix lint install script * chore: ignore and fix tests * fix lint and run gofmt * lint fixes * k8s executor image only * fix Makefile * fix travis env variables * more info on k8s tests * fix travis run * fix * fix * fix * fix log * some more changes * increase timeout * delete travis.yml and fix multiple copy tests * fix registry mirror * fix lint * add concurency * last attemot to fix k8 integrations * diff id for diff workflows * Fix composite cache key for multi-stage copy command (GoogleContainerTools#1706) PR GoogleContainerTools#1518 reintroduced COPY layers caching using the `--cache-copy-layers` flag. Unfortunately, this PR also introduced a bug by not including the stage digest into the caching key of the COPY command when the `--cache-copy-layers` flag was not set. As a result, kaniko would use any previous (possibly stalled) layer from the cache because the digest of the "COPY --from" command would never change. PR author probably expected Go to fallthrough in the switch just like C does. However, this is not the case. Go does not fallthrough in switch-statements by default and requires the fallthrough keyword to be used. Note that this keyword is not available in type-switches though, because it wouldn't work properly with typings. * refactor: add an abstract copy command interface to avoid code duplication * fix typo in error message Co-authored-by: Tejal Desai <[email protected]>
* Fix typo * Another typo
1. add s390x support to docker images `executor`, `executor(slim)`, `executor(debug)` and `warmer`. Fixes GoogleContainerTools#1462 and GoogleContainerTools#1665. 2. Address the building issue of dependency `docker-credential-gcr` in Dockerfiles. This issue was introduced when recent commits in `docker-credential-gcr` removed the Makefile. Signed-off-by: Kun-Lu <[email protected]> Co-authored-by: Kun-Lu <[email protected]>
…GoogleContainerTools#1722) * Remove tarball.WithCompressedCaching flag to resolve OOM Killed error Large images cannot be build as the kaniko container will be killed due to an OOM error. Removing the tarball compression drastically reduces the memory required to push large image layers. Fixes GoogleContainerTools#1680 This change may increase the build time for smaller images. Therefore a command line option to trigger the compression or a more intelligent behaviour may be useful. * Add new command line flag to toggle compressed caching * Add unittest for build with --compressed-caching command line flag set to false
* release: v1.7.0 * add self serve instructions: * more instructions * Update CHANGELOG.md
* run docker_credentials_gcr in warmer * fix tests * fix dockerfiles * fix boilerplate * mend * fix * another lint
* Revert "fix dockefiles for deploy" This reverts commit 63613ad. * revert unintentional test changes
* chore: add release workflow on pr * remove linux/s390x * use keys * set up platforms * cancel * update keys * add secrets to env * All platforms added for kaniko Co-authored-by: Kun-Lu <[email protected]> * echi * add mt 1300, remove push * Remove * final change * break executor and executor-slim Co-authored-by: Kun-Lu <[email protected]>
…s#1765) * git: accept explicit commit hash for git context When checking out code from non-github repositories, the typical assumptions may not be valid, e.g. that the only interesting non-branch commits have ref names starting with refs/pull. A specific example is fetching an un-merged commit from a gerrit repository by commit hash. This change just looks at the second part of the git context path and checks if it's a SHA commit hash, and if so, will fetch and check out this commit after cloning the repository. Sample context argument: https://github.repo/project#e1772f228e06d15facdf175e5385e265b57068c0 * ci: fix test script to recognize any non-zero exit as an error hack/linter.sh didn't properly install golangci-lint in hack/bin as I already have another version of golangci-lint on my PATH, but then it failed to execute because it was looking for it specifically in hack/bin. When the executable is not found, the exit code is 127 instead of 1, and so test.sh ignored the error. Two fixes: 1. `test.sh`: - Use `if (script) ...` instead of assigning / checking a result variable to determine if each validation script passed or failed. 2. `hack/linter.sh`: - Instead of checking for golangci-lint on the path, just specifically check for an executable file (`test -x`) in the expected location. Co-authored-by: Wade Carpenter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # in case of a bug fix, this should point to a bug and any other related issue(s)
Description
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.