pipeline: add render trigger func #547
Conversation
✅ Deploy Preview for kurator-dev canceled.
|
Signed-off-by: Xieql <[email protected]>
Xieql
changed the title
|
|
||
| // RenderTrigger takes a TriggerConfig object and generates YAML byte array configuration representing the trigger configuration. | ||
| func RenderTrigger(cfg TriggerConfig) ([]byte, error) { | ||
| return renderTemplate(TriggerTemplateContent, TriggerTemplateName, cfg) |
There was a problem hiding this comment.
same as other comments. do we need white space for TriggerTemplateName, as i cannot see the details
There was a problem hiding this comment.
Actually, 'TemplateName' is not a functioning variable, and it can contain spaces in the middle. see
IMHO, It is only required as a parameter for creating Go templates and more like a key for tpls.
There was a problem hiding this comment.
of cause, we can use "-" instead of space
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
part of #493
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: