Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add doc of setting up your pipeline #550

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

Xieql
Copy link
Contributor

@Xieql Xieql commented Jan 9, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

part of #493

Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for kurator-dev ready!

Name Link
🔨 Latest commit 347eda4
🔍 Latest deploy log https://app.netlify.com/sites/kurator-dev/deploys/659d3b25418c5c0008f673ab
😎 Deploy Preview https://deploy-preview-550--kurator-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Xieql Xieql force-pushed the doc-set-pipeline branch from 4f2549a to fdc8423 Compare January 9, 2024 09:32
Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan to add some other complex examples in other doc

kubectl apply --filename https://storage.googleapis.com/tekton-releases/chains/latest/release.yaml
```

### Configuring Authentication for Private Repositories
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: how can we make it optional

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's not necessary, then there's no need to configure it.

However, it is recommended that the documentation directly instructs users to configure this, as the authentication for later image uploads will also require users to use GitHub's PAT.

Additionally, this has only been tested with private repositories so far.

@kurator-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Xieql
Copy link
Contributor Author

Xieql commented Jan 9, 2024

Do you plan to add some other complex examples in other doc

yes!

this is just a doc for concept(Subdocument 1: Setting Up Your Pipeline), there still need two doc pr about:

  • Subdocument 2: Practical Operation Guide

  • Subdocument 3: Supply Chain Security

Signed-off-by: Xieql <[email protected]>
@Xieql
Copy link
Contributor Author

Xieql commented Jan 9, 2024

/label tide/merge-method-squash

Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK
/lgtm

@kurator-bot kurator-bot merged commit 61c0e45 into kurator-dev:main Jan 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants