-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add doc of setting up your pipeline #550
Conversation
✅ Deploy Preview for kurator-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Xieql <[email protected]>
4f2549a
to
fdc8423
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you plan to add some other complex examples in other doc
kubectl apply --filename https://storage.googleapis.com/tekton-releases/chains/latest/release.yaml | ||
``` | ||
|
||
### Configuring Authentication for Private Repositories |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: how can we make it optional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's not necessary, then there's no need to configure it.
However, it is recommended that the documentation directly instructs users to configure this, as the authentication for later image uploads will also require users to use GitHub's PAT.
Additionally, this has only been tested with private repositories so far.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yes! this is just a doc for concept(Subdocument 1: Setting Up Your Pipeline), there still need two doc pr about:
|
Signed-off-by: Xieql <[email protected]>
/label tide/merge-method-squash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
/lgtm
What type of PR is this?
/kind documentation
What this PR does / why we need it:
part of #493