Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add handling for getting rollout status #556

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

LiZhenCheng9527
Copy link
Contributor

What type of PR is this?
/kind feature
What this PR does / why we need it:
add handling for getting rollout status
Which issue(s) this PR fixes:
Fixes #435

Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for kurator-dev canceled.

Name Link
🔨 Latest commit 46260c5
🔍 Latest deploy log https://app.netlify.com/sites/kurator-dev/deploys/659e91587eda690008de089b

Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

}
}

log.Info("finish get rollout status")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
log.Info("finish get rollout status")
log.Info("finished getting rollout status")

@kurator-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kurator-bot kurator-bot merged commit 950b692 into kurator-dev:main Jan 11, 2024
9 checks passed
@LiZhenCheng9527 LiZhenCheng9527 deleted the rollout-status branch January 17, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]Provide a CI/CD Solution for Kurator
3 participants