pipeline: init pipeline controller #559
Conversation
Signed-off-by: Xieql <[email protected]>
✅ Deploy Preview for kurator-dev canceled.
|
Xieql
force-pushed
the
pipeline-controller
branch
2 times, most recently
from
6f47fd5 to
4946731
Compare
Signed-off-by: Xieql <[email protected]>
Xieql
force-pushed
the
pipeline-controller
branch
from
4946731 to
8e5ccff
Compare
|
|
||
| const ( | ||
| PipelineFinalizer = "pipeline.kurator.dev" | ||
| TektonPipelineLabel = "tekton.dev/pipeline" |
There was a problem hiding this comment.
kurator.dev, lets keep align with other labels
There was a problem hiding this comment.
I dont think so. This label is tekton label. I add it here because the pod is create by tekton and they have tekton label.
If I want to delete them esaily, I need client.MatchingLabels{TektonPipelineLabel: pipelineName} to find those pod.
There was a problem hiding this comment.
IC， can we use it from pipelineapi if It exists there
| return nil | ||
| } | ||
|
|
||
| // getListenerServiceName get the name of event listener service name. This naming way is origin from tekton controller. |
There was a problem hiding this comment.
In my test case, the name adheres to this pattern. It is not a functional function, and it is just displayed in the status.
I tried searching for it directly, but couldn't find it. I suppose I need to delve into the code to examine its logic. I will provide the link when I have time later on.
Signed-off-by: Xieql <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind design
/kind feature
What this PR does / why we need it:
part of #493
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: