[TransferEngine] Suppress gtest type cast compile warning and fix some trivial bugs #115
+35
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuan-luo
changed the title
alogfans
reviewed
Feb 21, 2025
| @@ -53,7 +53,7 @@ static inline int bindToSocket(int socket_id) { | |||
| struct bitmask *cpu_list = numa_allocate_cpumask(); | |||
| numa_node_to_cpus(socket_id, cpu_list); | |||
| int nr_cpus = 0; | |||
| for (int cpu = 0; cpu < numa_num_possible_cpus(); ++cpu) { | |||
| for (int cpu = 0; cpu < num_nodes; ++cpu) { | |||
There was a problem hiding this comment.
Should not changed. num_node means the number of NUMA nodes, not the number of cores (numa_num_possible_cpus()). For example, a machine with 2 48-core CPUs, numa_num_possible_cpus()==96 and num_node==2.
yuan-luo
force-pushed
the
gtest_refine
branch
from
bfcc130 to
2413445
Compare
|
LGTM |
doujiang24
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress gtest compile warning and fix some trivial bugs.