Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add params, use open-uri #4

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

sjoeboo
Copy link

@sjoeboo sjoeboo commented Jun 29, 2016

This PR does a few things:

  • Adds a params.pp with new parameters allowing the end user to set the cache_dir, cache_ttl, and api_url (there is a sandbox.api ). This moves the defaults to params.pp per usual and init.pp inherits from that.
  • Swaps out how the fact talks to the api, officially from Dell sending the apikey in the URL is a no-no, and the api can accept the apikey in the headers, so this swaps out the http work for a method that does that.
  • Otherwise just sets up the fact to use the cache_dir + ttl from the config written, as well as the api_url.

(FYI, a private PAI key can be obtained by asking dell, there is a...enrollment process)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant