refactor: remove unnecessary current_screen arg from `App::init_det…

…ails_actions`

The method `App::init_details_actions`, used to initialize an instance
of the screen "Patchset Details and Actions", has an argument
`current_screen` to resolve if the patchset to be opened is from the
latest or bookmarked patchsets. However, this can be resolved by just
checking the field `App::current_screen`, so remove this unnecessary
argument.

Signed-off-by: David Tadokoro <[email protected]>

src/app.rs

@@ -124,14 +124,11 @@ impl App {
     /// Initializes field [App::details_actions], from currently selected
     /// patchset in [App::bookmarked_patchsets] or [App::latest_patchsets],
     /// depending on the value of [App::current_screen].
-    pub fn init_details_actions(
-        &mut self,
-        current_screen: CurrentScreen,
-    ) -> color_eyre::Result<()> {
+    pub fn init_details_actions(&mut self) -> color_eyre::Result<()> {
         let representative_patch: Patch;
         let mut is_patchset_bookmarked = true;
 
-        match current_screen {
+        match &self.current_screen {
             CurrentScreen::BookmarkedPatchsets => {
                 representative_patch = self.bookmarked_patchsets.get_selected_patchset();
             }
@@ -190,7 +187,7 @@ impl App {
                         (PatchsetAction::Bookmark, is_patchset_bookmarked),
                         (PatchsetAction::ReplyWithReviewedBy, false),
                     ]),
-                    last_screen: current_screen,
+                    last_screen: self.current_screen.clone(),
                     lore_api_client: self.lore_api_client.clone(),
                 });
                 Ok(())

src/handler/bookmarked.rs

@@ -33,7 +33,7 @@ where
             terminal = loading_screen! {
                 terminal,
                 "Loading patchset" => {
-                    app.init_details_actions(CurrentScreen::BookmarkedPatchsets)?;
+                    app.init_details_actions()?;
                     app.set_current_screen(CurrentScreen::PatchsetDetails);
                 }
             };

src/handler/latest.rs

@@ -48,7 +48,7 @@ where
             terminal = loading_screen! {
                 terminal,
                 "Loading patchset" => {
-                    app.init_details_actions(CurrentScreen::LatestPatchsets)?;
+                    app.init_details_actions()?;
                     app.set_current_screen(CurrentScreen::PatchsetDetails);
                 }
             };