Hold git commit (revision) as a old_rev new_rev

To prevent miss-detect of " (downgrade)" indication.
kyanny · Feb 16, 2014 · f6bea3b · f6bea3b
1 parent 45e0b80
commit f6bea3b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/lib/compare_linker/formatter/markdown.rb b/lib/compare_linker/formatter/markdown.rb
@@ -7,8 +7,8 @@ def format(gem_info)
         g = OpenStruct.new(gem_info)
 
         text = case
-        when g.owner
-          "* #{g.gem_name}: https://github.com/#{g.owner}/#{g.gem_name}/compare/#{g.old_ver}...#{g.new_ver}"
+        when g.owner && g.old_rev && g.new_rev
+          "* #{g.gem_name}: https://github.com/#{g.owner}/#{g.gem_name}/compare/#{g.old_rev}...#{g.new_rev}"
         when g.homepage_uri
           "* [#{g.gem_name}](#{g.homepage_uri}): #{g.old_ver} => #{g.new_ver}"
         when g.old_tag && g.new_tag

diff --git a/lib/compare_linker/formatter/text.rb b/lib/compare_linker/formatter/text.rb
@@ -7,8 +7,8 @@ def format(gem_info)
         g = OpenStruct.new(gem_info)
 
         text = case
-        when g.owner
-          "#{g.gem_name}: https://github.com/#{g.owner}/#{g.gem_name}/compare/#{g.old_ver}...#{g.new_ver}"
+        when g.owner && g.old_rev && g.new_rev
+          "#{g.gem_name}: https://github.com/#{g.owner}/#{g.gem_name}/compare/#{g.old_rev}...#{g.new_rev}"
         when g.homepage_uri
           "#{g.gem_name} (#{g.homepage_uri}): #{g.old_ver} => #{g.new_ver}"
         when g.old_tag && g.new_tag

diff --git a/lib/compare_linker/lockfile_comparator.rb b/lib/compare_linker/lockfile_comparator.rb
@@ -17,8 +17,8 @@ def compare(old_lockfile, new_lockfile)
               updated_gems[old_spec.name] = {
                 owner: owner,
                 gem_name: gem_name,
-                old_ver: old_rev,
-                new_ver: new_rev,
+                old_rev: old_rev,
+                new_rev: new_rev,
               }
             elsif old_spec.version != new_spec.version
               updated_gems[old_spec.name] = {