update c++11 lambda for CAPropertyAddressList #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleneideck
reviewed
Dec 8, 2024
| @@ -162,8 +136,8 @@ class CAPropertyAddressList | |||
|
|
|||
| #pragma clang diagnostic push | |||
| #pragma clang diagnostic ignored "-Wdeprecated" | |||
There was a problem hiding this comment.
I tried deleting these pragmas, and the ones below, and it still builds (in Xcode 16.1). Do you think we can delete them now?
Other than that question, this PR looks good to me.
kyleneideck
approved these changes
Dec 8, 2024
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactoring improvement to support c++11.