Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ui5 codemod adjustments #3449

Merged
merged 4 commits into from
Nov 6, 2024
Merged

fix: Ui5 codemod adjustments #3449

merged 4 commits into from
Nov 6, 2024

Conversation

OliwiaGowor
Copy link
Contributor

@OliwiaGowor OliwiaGowor commented Nov 4, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • adjustments made with UI5 Web Components for React codemod

Related issue(s)
#3422

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 4, 2024
@OliwiaGowor OliwiaGowor marked this pull request as ready for review November 4, 2024 18:05
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 4, 2024
mrCherry97
mrCherry97 requested changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@mrCherry97 mrCherry97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check warning on line 23 in src/components/Clusters/views/ClusterOverview/ClusterValidation/ClusterValidation.tsx
'Loader' is defined but never used

What about badges in extensibility? Are changes with warning -> critical affecting anything?

src/shared/components/DynamicPageComponent/DynamicPageComponent.js Outdated
@@ -20,6 +20,8 @@ import { isResourceEditedState } from 'state/resourceEditedAtom';
import { isFormOpenState } from 'state/formOpenAtom';
import { handleActionIfFormOpen } from '../UnsavedMessageBox/helpers';

import { ObjectPageHeader } from '@ui5/webcomponents-react';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { ObjectPageHeader } from '@ui5/webcomponents-react';

@OliwiaGowor
Copy link
Contributor Author

For the badges, there needs to be done whole badges component adjustment because of those changes. I would propose to do it in separate PR. The small change in this PR won't affect extensibility.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 6, 2024
@mrCherry97 mrCherry97 merged commit 0ff4119 into kyma-project:ui5-migrate-v2 Nov 6, 2024
6 of 13 checks passed
@OliwiaGowor OliwiaGowor mentioned this pull request Nov 7, 2024
Closed
@OliwiaGowor OliwiaGowor deleted the ui5-codemode-adjustments branch November 8, 2024 13:56
mrCherry97 added a commit that referenced this pull request Jan 29, 2025
@mrCherry97 @OliwiaGowor
@chriskari @akucharska @IwonaLanger @dbadura @grego952
chore: update UI5 from v1 to v2 (#3542)
86b9ab4 
* chore: UI5 bump packages (#3439)

* chore: update packages

* chore: bump ui5-react

* fix: adjust tests to not use enzyme

* chore: fix dependencies

* fix: remove unused

* fix: remove not existing import

* chore: add compatibility package

* fix: adjust render, css names and imports (#3440)

* fix: change render

* fix: adjust css names

* fix: change imports for Toolbar

* fix: change imports for tables

* fix: rename list comp. & badge

* fix: fix imports

* chore: adjust spacing to classNames (#3442)

* change some spacing to new classnames

* fix merge

* pray to god, that everything is working

* pray to god, that everything is working

* some spacing and iconEnd for ExternalLink

* some spacing and iconEnd for SA token

* add no-margin class in index.scss

* adjust the rest of the spacing

* remove unused impott

* fix stupid classNames

* adjust separatorLine to tsx and use style prop

* review changes

* fix: Ui5 codemod adjustments (#3449)

* fix: ui5 codemode adjustments

* fix: fix imports

* fix: fix table imports

* fix: fix unused

* fix: adjust DynamicPageComponent (#3445)

* fix: adjust dynamicPage

* fix: separate actionsBar

* fix: fix actions behavior

* fix: remove unused

* fix: fix classNames

* fix: fix empty toolbar & move banners

* fix: fix dependency

* fix: remove spacing file

* fix: toast adjustments (#3462)

* fix: adjust tokens (#3463)

* fix: adjust tokens

* fix: adjust spacing

* fix: adjust badges (#3464)

* fix: adjust badges type names

* fix: fix type mappings

* fix: remove console.log

* fix: adjust headers size (#3467)

* fix: add 'size' to headers

* fix: add size to headers

* fix: defaultProps (#3469)

* remove defaultProps and disableEdit prop from resourcelist

* Update src/shared/components/ResourcesList/ResourcesList.js

Co-authored-by: Oliwia Gowor <[email protected]>

---------

Co-authored-by: Oliwia Gowor <[email protected]>

* fix: spinner size (#3474)

* fix: theme (#3475)

* fix: adjust forms (#3473)

* fix: fix styling and alerts

* fix: fix unsaved message

* fix: fix background in add modules

* fix: remove unused

* fix: passing props

* fix: key error

* fix: resources in list

* fix: adjust Preferences modal (#3476)

* fix: adjust Preferences modal

* fix: move import

* fix: opening preferences menu

* fix: list props

* fix: props

* fix: objectPageHeader styling and modules card (#3487)

* fix: Ui5 console errors (#3486)

* fix: key errors

* fix: fetch error

* fix: monaco worker fix

* fix: dynamicPage header error

* fix: small fixes

* fix: review fixes

* fix: adjust V1 Tables (#3491)

* fix: adjust tables

* fix: emptyListComp flickering

* fix: adjust reset.css

* fix: change logo acc name (#3518)

* remove unnecessary css code from reset.css & some minor adjustments (#3524)

* fix: Busola is flickering when ObjectPage is opened (#3498)

* fix: fix flickering on column layout

* fix: remove unused

* fix: replace DynamicPage with ObjectPage

* fix: fix key error

* fix: banner height and remove unused

* fix: initial render flicker

* fix: change to DynamicPage

* hotfix

* Replace props spread

* hotfix

* fix: shadow & unused

* fix: shadow & sticky tabs

* fix: hide button everywhere

---------

Co-authored-by: mrCherry97 <[email protected]>
Co-authored-by: akucharska <[email protected]>

* fix: selected in lists (#3543)

Co-authored-by: Oliwia Gowor <[email protected]>

* fix: Fix delete cluster action (#3540)

* Fix delete cluster action

* fix: Toast is hidden behind Dialogs (#3538)

* Revert "Merge branch 'main' into ui5-migrate-v2"

This reverts commit 79fb867, reversing
changes made to 5b7fd61.

* fix: selected in lists (#3539)

* fix: toasts in dialogs

* fix: adjust Cypress tests (#3553)

* fix: adjust tests

* fix: adjust more tests

* fix: selected in list

* comment out rebase action

* comment out rebase action v2

* fix: create namespace

* fix: adjust comboboxes

* fix: adjust tests

* fix: add wait

* cleanup

* chore: add unsafe eval for accessibility tests (#3554)

* fix: small leftover bugs  (#3555)

* fix: small fixes

* fix: ProgressIndicator colors

* fix: sidebar z-index

* fix: acc tests

* fix: more acc

* feat: migrate UI5 vitest unit tests to cypress component tests (#3551)

* cypress config for component testing

* first tests migration

* migrated badge tests

* migrated generic list

* migrated counting card

* migrated copiable text

* migrated namespace settings

* migrated ui5radial chart

* migrated podrestarts

* migrated errorboundary

* migrated pagination

* migrated listactions

* migrated resourcenotfound

* migrated modalwithform

* migrated helmreleases

* migrated selector

* migrated ResourceLink

* migrated controlledby

* mocked ui5 dependencies in nodeQueries test

* migrated JoinedArray

* migrated CodeViewer

* mocked ui5 dependencies in useCreateResource test

* mocked ui5 dependencies in useGetCRDByPath

* migrated Columns

* migrated Widget

* mocked ui5 dependencies in linkExtractor

* migrated SecretData

* migrated SideDrawer

* migrated ResourceDetailsColumns

* migrated ResourceDetailsVisibility

* fixed issues in tests

* migrated Table

* mocked ui5 dependencies in Widget.copyable

* fixed useGet test

* refined vitest

* adjust github actions workflow

* adjust github actions workflow

* added command for headless component tests

* add cypress as dev dependency

* fixed genericList test

* adjusted testing-strategy.md

* Update docs/contributor/testing-strategy.md

Co-authored-by: Iwona Langer <[email protected]>

---------

Co-authored-by: Oliwia Gowor <[email protected]>
Co-authored-by: Iwona Langer <[email protected]>

* fix: theme on initial and refresh (#3565)

* fix: combobox (#3588)

* fix: Command Palette shouldn't navigate when Form is edited  (#3583)

* fix: command palette and form + tests

* fix: badge test

* fix: keyboard navigation

* fix: adjust styles (#3595)

* fix: open dropdown popover correctly (#3594)

* fix: dropdown popover opens correctly

* test: added component test for Dropdown component

* fix: remove empty selectedKey property

* fix: remove unused css & small changes (#3599)

* fix: container selector (#3597)

* fix: remove unused proprtey from KymaModulesAddModule

* fix: remove unnecessary css from FormGroup

* fix: @container selector for featurecard

* fix: @container selector for ClusterStats

* fix: @container selector for rest of the components

* fix: small styling fixes

* test: adjust viewport for pagination component test

* test: fix flakiness for pvc test

* fix: change classnames to be less generic

* test: adjust unit test workflow (#3609)

* fix: UI5 adjust badges (#3619)

* fix: adjust badges

* fix: add checkBeta back

* fix: adjust Web Components to React 18 (#3622)

* fix: adjust badges after overriding functionality (#3627)

* fix: adjust badges

* adjust test

* Update docs/contributor/testing-strategy.md

Co-authored-by: Grzegorz Karaluch <[email protected]>

* fix: undefined in data sources (#3633)

* fix: undefined in state

* fix: stabilize test

* fix: stabilize navigation test

* fix: stabilize tests?

* move wait for cr test

---------

Co-authored-by: Oliwia Gowor <[email protected]>
Co-authored-by: Christian Karidas <[email protected]>
Co-authored-by: akucharska <[email protected]>
Co-authored-by: Oliwia Gowor <[email protected]>
Co-authored-by: Agata Kucharska <[email protected]>
Co-authored-by: Iwona Langer <[email protected]>
Co-authored-by: Damian Badura <[email protected]>
Co-authored-by: Grzegorz Karaluch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrCherry97 mrCherry97 mrCherry97 approved these changes

@akucharska akucharska Awaiting requested review from akucharska

@dbadura dbadura Awaiting requested review from dbadura

@chriskari chriskari Awaiting requested review from chriskari

Assignees

@mrCherry97 mrCherry97

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OliwiaGowor @mrCherry97 @kyma-bot