Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom web component based extension #3471

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Custom web component based extension #3471

wants to merge 15 commits into from

Conversation

pbochynski
Copy link
Contributor

Description

Changes proposed in this pull request:

  • custom web component loaded as busola extension

Related issue(s)

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 12, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 12, 2024
View reviewed changes
backend/proxy.js Fixed Show fixed Hide fixed
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 15, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 15, 2024
@chriskari chriskari linked an issue Nov 15, 2024 that may be closed by this pull request
[Spike] Load dynamically custom web component from URL hosted in the kubernetes cluster #3456
Closed
4 tasks
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 18, 2024
mrCherry97
mrCherry97 reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@mrCherry97 mrCherry97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion looks good, there is some console.logs which I don't know if they are necessary, and <div></div> -> <div /> but it's more PoC/MVP, so it's fine, I'll consider changing
extCustomComponentsEnabled: boolean | undefined, -> extCustomComponentsEnabled: boolean, and calling useFeature() should set isExtensibilityCustomComponentsEnabled on false if it's undefined, but we should also change it for every feature flags.

@chriskari
Copy link
Contributor

chriskari commented Nov 20, 2024 •
edited
Loading

Regarding the <div></div>, I did some research about insertion of web components and,

If the web component relies on its full DOM lifecycle methods like connectedCallback(), a self-closing tag might interrupt or prevent proper initialization. The full closing tag ensures the entire element is parsed correctly, allowing web component constructors and connection callbacks to execute fully.

@dbadura
Copy link
Contributor

dbadura commented Nov 22, 2024

Looks good for me

@dbadura dbadura removed their assignment Nov 22, 2024
@OliwiaGowor
Copy link
Contributor

Looks good to me

akucharska
akucharska reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@akucharska akucharska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pbochynski pbochynski mentioned this pull request Nov 25, 2024
Closed
6 tasks
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 29, 2024
@chriskari chriskari linked an issue Dec 5, 2024 that may be closed by this pull request
Custom busola extensions #3497
Closed
6 tasks
@chriskari chriskari removed a link to an issue Dec 6, 2024
Custom busola extensions #3497
Closed
6 tasks
@chriskari chriskari mentioned this pull request Dec 9, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrCherry97 mrCherry97 mrCherry97 left review comments

@akucharska akucharska akucharska left review comments

@dbadura dbadura Awaiting requested review from dbadura dbadura will be requested when the pull request is marked ready for review dbadura is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari will be requested when the pull request is marked ready for review chriskari is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor will be requested when the pull request is marked ready for review OliwiaGowor is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@akucharska akucharska

@mrCherry97 mrCherry97

@OliwiaGowor OliwiaGowor

Labels
cla: yes Indicates the PR's author has signed the CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Spike] Load dynamically custom web component from URL hosted in the kubernetes cluster
7 participants
@pbochynski @chriskari @dbadura @OliwiaGowor @akucharska @mrCherry97 @kyma-bot