Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Reuse POC's UI and state #3512

Merged
merged 9 commits into from
Jan 31, 2025
Merged

feat: Reuse POC's UI and state #3512

merged 9 commits into from
Jan 31, 2025

Conversation

chriskari
Copy link
Contributor

@chriskari chriskari commented Dec 2, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • reused most of the work that has been done in the POC (UI and state)
  • transformed files to use Typescript
  • left some deprecated features such as creation of sessionID, page-wise opener etc.

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 2, 2024
@chriskari chriskari changed the base branch from kyma-companion to main January 14, 2025 13:36
This was referenced Jan 17, 2025
Closed
Open
Open
Open
Open
Open
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 21, 2025
@chriskari chriskari changed the title feat: reuse basic framework of the POC feat: reuse POC's UI and state Jan 21, 2025
@chriskari chriskari mentioned this pull request Jan 21, 2025
Open
4 tasks
@chriskari chriskari linked an issue Jan 21, 2025 that may be closed by this pull request
Migrate Kyma Companion to UI5v2 #3600
Closed
4 tasks
@chriskari chriskari changed the title feat: reuse POC's UI and state Feat: reuse POC's UI and state Jan 29, 2025
@chriskari chriskari changed the title Feat: reuse POC's UI and state feat: Reuse POC's UI and state Jan 29, 2025
akucharska
akucharska reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@akucharska akucharska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.
One thing I noticed is a bigger gap between companion and the rest of Busola (thanks to the margins on companion_wrapper and html-wrap) than in other split views

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 31, 2025
@chriskari chriskari merged commit b1b77d8 into kyma-project:main Jan 31, 2025
44 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akucharska akucharska akucharska left review comments

@grego952 grego952 grego952 approved these changes

@mrCherry97 mrCherry97 mrCherry97 approved these changes

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@akucharska akucharska

@mrCherry97 mrCherry97

@grego952 grego952

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Kyma Companion to UI5v2
5 participants
@chriskari @akucharska @mrCherry97 @grego952 @kyma-bot