fix: small leftover bugs #3555
Merged
fix: small leftover bugs #3555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
do-not-merge/work-in-progress
kyma-bot
added
size/M
OliwiaGowor
requested review from
akucharska,
mrCherry97,
dbadura and
chriskari
as code owners
kyma-bot
removed
the
do-not-merge/work-in-progress
akucharska
approved these changes
Dec 24, 2024
OliwiaGowor
merged commit 413b65f
into
kyma-project:ui5-migrate-v2
12 of 14 checks passed
mrCherry97
added a commit
that referenced
this pull request
Jan 29, 2025
* chore: UI5 bump packages (#3439) * chore: update packages * chore: bump ui5-react * fix: adjust tests to not use enzyme * chore: fix dependencies * fix: remove unused * fix: remove not existing import * chore: add compatibility package * fix: adjust render, css names and imports (#3440) * fix: change render * fix: adjust css names * fix: change imports for Toolbar * fix: change imports for tables * fix: rename list comp. & badge * fix: fix imports * chore: adjust spacing to classNames (#3442) * change some spacing to new classnames * fix merge * pray to god, that everything is working * pray to god, that everything is working * some spacing and iconEnd for ExternalLink * some spacing and iconEnd for SA token * add no-margin class in index.scss * adjust the rest of the spacing * remove unused impott * fix stupid classNames * adjust separatorLine to tsx and use style prop * review changes * fix: Ui5 codemod adjustments (#3449) * fix: ui5 codemode adjustments * fix: fix imports * fix: fix table imports * fix: fix unused * fix: adjust DynamicPageComponent (#3445) * fix: adjust dynamicPage * fix: separate actionsBar * fix: fix actions behavior * fix: remove unused * fix: fix classNames * fix: fix empty toolbar & move banners * fix: fix dependency * fix: remove spacing file * fix: toast adjustments (#3462) * fix: adjust tokens (#3463) * fix: adjust tokens * fix: adjust spacing * fix: adjust badges (#3464) * fix: adjust badges type names * fix: fix type mappings * fix: remove console.log * fix: adjust headers size (#3467) * fix: add 'size' to headers * fix: add size to headers * fix: defaultProps (#3469) * remove defaultProps and disableEdit prop from resourcelist * Update src/shared/components/ResourcesList/ResourcesList.js Co-authored-by: Oliwia Gowor <[email protected]> --------- Co-authored-by: Oliwia Gowor <[email protected]> * fix: spinner size (#3474) * fix: theme (#3475) * fix: adjust forms (#3473) * fix: fix styling and alerts * fix: fix unsaved message * fix: fix background in add modules * fix: remove unused * fix: passing props * fix: key error * fix: resources in list * fix: adjust Preferences modal (#3476) * fix: adjust Preferences modal * fix: move import * fix: opening preferences menu * fix: list props * fix: props * fix: objectPageHeader styling and modules card (#3487) * fix: Ui5 console errors (#3486) * fix: key errors * fix: fetch error * fix: monaco worker fix * fix: dynamicPage header error * fix: small fixes * fix: review fixes * fix: adjust V1 Tables (#3491) * fix: adjust tables * fix: emptyListComp flickering * fix: adjust reset.css * fix: change logo acc name (#3518) * remove unnecessary css code from reset.css & some minor adjustments (#3524) * fix: Busola is flickering when ObjectPage is opened (#3498) * fix: fix flickering on column layout * fix: remove unused * fix: replace DynamicPage with ObjectPage * fix: fix key error * fix: banner height and remove unused * fix: initial render flicker * fix: change to DynamicPage * hotfix * Replace props spread * hotfix * fix: shadow & unused * fix: shadow & sticky tabs * fix: hide button everywhere --------- Co-authored-by: mrCherry97 <[email protected]> Co-authored-by: akucharska <[email protected]> * fix: selected in lists (#3543) Co-authored-by: Oliwia Gowor <[email protected]> * fix: Fix delete cluster action (#3540) * Fix delete cluster action * fix: Toast is hidden behind Dialogs (#3538) * Revert "Merge branch 'main' into ui5-migrate-v2" This reverts commit 79fb867, reversing changes made to 5b7fd61. * fix: selected in lists (#3539) * fix: toasts in dialogs * fix: adjust Cypress tests (#3553) * fix: adjust tests * fix: adjust more tests * fix: selected in list * comment out rebase action * comment out rebase action v2 * fix: create namespace * fix: adjust comboboxes * fix: adjust tests * fix: add wait * cleanup * chore: add unsafe eval for accessibility tests (#3554) * fix: small leftover bugs (#3555) * fix: small fixes * fix: ProgressIndicator colors * fix: sidebar z-index * fix: acc tests * fix: more acc * feat: migrate UI5 vitest unit tests to cypress component tests (#3551) * cypress config for component testing * first tests migration * migrated badge tests * migrated generic list * migrated counting card * migrated copiable text * migrated namespace settings * migrated ui5radial chart * migrated podrestarts * migrated errorboundary * migrated pagination * migrated listactions * migrated resourcenotfound * migrated modalwithform * migrated helmreleases * migrated selector * migrated ResourceLink * migrated controlledby * mocked ui5 dependencies in nodeQueries test * migrated JoinedArray * migrated CodeViewer * mocked ui5 dependencies in useCreateResource test * mocked ui5 dependencies in useGetCRDByPath * migrated Columns * migrated Widget * mocked ui5 dependencies in linkExtractor * migrated SecretData * migrated SideDrawer * migrated ResourceDetailsColumns * migrated ResourceDetailsVisibility * fixed issues in tests * migrated Table * mocked ui5 dependencies in Widget.copyable * fixed useGet test * refined vitest * adjust github actions workflow * adjust github actions workflow * added command for headless component tests * add cypress as dev dependency * fixed genericList test * adjusted testing-strategy.md * Update docs/contributor/testing-strategy.md Co-authored-by: Iwona Langer <[email protected]> --------- Co-authored-by: Oliwia Gowor <[email protected]> Co-authored-by: Iwona Langer <[email protected]> * fix: theme on initial and refresh (#3565) * fix: combobox (#3588) * fix: Command Palette shouldn't navigate when Form is edited (#3583) * fix: command palette and form + tests * fix: badge test * fix: keyboard navigation * fix: adjust styles (#3595) * fix: open dropdown popover correctly (#3594) * fix: dropdown popover opens correctly * test: added component test for Dropdown component * fix: remove empty selectedKey property * fix: remove unused css & small changes (#3599) * fix: container selector (#3597) * fix: remove unused proprtey from KymaModulesAddModule * fix: remove unnecessary css from FormGroup * fix: @container selector for featurecard * fix: @container selector for ClusterStats * fix: @container selector for rest of the components * fix: small styling fixes * test: adjust viewport for pagination component test * test: fix flakiness for pvc test * fix: change classnames to be less generic * test: adjust unit test workflow (#3609) * fix: UI5 adjust badges (#3619) * fix: adjust badges * fix: add checkBeta back * fix: adjust Web Components to React 18 (#3622) * fix: adjust badges after overriding functionality (#3627) * fix: adjust badges * adjust test * Update docs/contributor/testing-strategy.md Co-authored-by: Grzegorz Karaluch <[email protected]> * fix: undefined in data sources (#3633) * fix: undefined in state * fix: stabilize test * fix: stabilize navigation test * fix: stabilize tests? * move wait for cr test --------- Co-authored-by: Oliwia Gowor <[email protected]> Co-authored-by: Christian Karidas <[email protected]> Co-authored-by: akucharska <[email protected]> Co-authored-by: Oliwia Gowor <[email protected]> Co-authored-by: Agata Kucharska <[email protected]> Co-authored-by: Iwona Langer <[email protected]> Co-authored-by: Damian Badura <[email protected]> Co-authored-by: Grzegorz Karaluch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#3422
Definition of done
backlog#4567