Add Kyma Access command to CLI #2067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
kyma-bot
added
cla: yes
Cortey
added
area/cli
pPrecel
reviewed
May 13, 2024
internal/cmd/access/access.go
Outdated
| cmd.Flags().StringVar(&cfg.name, "name", "", "Name of the Service Account to be created") | ||
| cmd.Flags().StringVar(&cfg.clusterrole, "clusterrole", "", "Name of the cluster role to bind the Service Account") | ||
| cmd.Flags().StringVar(&cfg.output, "output", "", "Path to the output kubeconfig file") | ||
| cmd.Flags().StringVar(&cfg.namespace, "namespace", "default", "Namespace ") |
There was a problem hiding this comment.
I would suggest to improve the --namespace flag :)
internal/cmd/access/access.go
Outdated
| }, | ||
| } | ||
| _, err := cfg.KubeClient.Static().RbacV1().ClusterRoles().Create(cfg.Ctx, &cRole, metav1.CreateOptions{}) | ||
| if client.IgnoreNotFound(err) == nil { |
There was a problem hiding this comment.
I would suggest to replace client.IngoreNotFound with errors.IsAlreadyExists from the k8s.io/apimachinery/pkg/api/errors. I think the Create func will never return a not found error because in this case this func will just create it
pPrecel
approved these changes
May 13, 2024
pPrecel
pushed a commit
to pPrecel/cli
that referenced
this pull request
May 21, 2024
* v1 * v12 * print * workingv1 * accesscommand * cut function into pieces this is my last resort * typo * cleanup * long * gomodtidy * review --------- Co-authored-by: Piotr Halama <[email protected]>
pPrecel
pushed a commit
that referenced
this pull request
May 21, 2024
* v1 * v12 * print * workingv1 * accesscommand * cut function into pieces this is my last resort * typo * cleanup * long * gomodtidy * review --------- Co-authored-by: Piotr Halama <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a command that creates a kubeconfig that includes token and certificate for specially crafted service account with admin access rights
Related issue(s)