Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the resources package #2312

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Refactor the resources package #2312

merged 1 commit into from
Jan 15, 2025

Conversation

pPrecel
Copy link
Contributor

@pPrecel pPrecel commented Jan 13, 2025

Description

Changes proposed in this pull request:

  • improve test cases
  • split one file into smaller ones

Related issue(s)

@pPrecel pPrecel added area/cli Related to all activities around CLI kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jan 13, 2025
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 13, 2025
@pPrecel
Copy link
Contributor Author

pPrecel commented Jan 13, 2025

This PR is based on changes proposed in the previous one

@pPrecel pPrecel force-pushed the app-push-mounts-refactor branch from a0bdd01 to 9119792 Compare January 14, 2025 15:43
@pPrecel pPrecel marked this pull request as ready for review January 14, 2025 15:44
@pPrecel pPrecel requested a review from a team as a code owner January 14, 2025 15:44
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 14, 2025
@halamix2 halamix2 self-assigned this Jan 15, 2025
halamix2
halamix2 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@halamix2 halamix2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/pony

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 15, 2025
@kyma-bot
Copy link

@halamix2: pony image

In response to this:

/pony

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pPrecel pPrecel merged commit 2c73dcb into kyma-project:main Jan 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halamix2 halamix2 halamix2 approved these changes

Assignees

@halamix2 halamix2

Labels
area/cli Related to all activities around CLI cla: yes Indicates the PR's author has signed the CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pPrecel @kyma-bot @halamix2