Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework modules list #2343

Merged
merged 5 commits into from
Feb 12, 2025
Merged

Rework modules list #2343

merged 5 commits into from
Feb 12, 2025

Conversation

pPrecel
Copy link
Contributor

@pPrecel pPrecel commented Feb 10, 2025

Description

Changes proposed in this pull request:

  • rework the kyma alpha module list command to treat the Kyma CR as a main source of truth

Related issue(s)

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 10, 2025
@pPrecel pPrecel force-pushed the rework-modules-list branch from 48510ce to 851711c Compare February 11, 2025 11:29
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 11, 2025
@pPrecel pPrecel marked this pull request as ready for review February 11, 2025 11:36
@pPrecel pPrecel requested a review from a team as a code owner February 11, 2025 11:36
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 11, 2025
@pPrecel pPrecel enabled auto-merge (squash) February 11, 2025 13:14
@halamix2 halamix2 self-assigned this Feb 11, 2025
Copy link
Member

@halamix2 halamix2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/pony

@pPrecel pPrecel merged commit 5f7c3e9 into kyma-project:main Feb 12, 2025
4 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 12, 2025
@kyma-bot
Copy link

@halamix2: pony image

In response to this:

/pony

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants