Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panic caused by nuke reconciler when scope not exists. #1016

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

ravi-shankar-sap
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Check for nil Scope in provider Predicates.

Related issue(s)

Fixes #https://github.tools.sap/kyma/cloud-manager-infra/issues/17

@ravi-shankar-sap ravi-shankar-sap requested a review from a team as a code owner February 7, 2025 19:03
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 7, 2025
Copy link
Contributor

@abalaie abalaie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 7, 2025
@ravi-shankar-sap ravi-shankar-sap merged commit d526787 into kyma-project:main Feb 7, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants