Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(GcpNfsVolumeBackup/Restore) optional nfsvolume ref namespace #586

Merged
merged 1 commit into from
Sep 6, 2024
Merged

fix(GcpNfsVolumeBackup/Restore) optional nfsvolume ref namespace #586

merged 1 commit into from
Sep 6, 2024

Conversation

ravi-shankar-sap
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Optional value for GcpNfsVolumeBackup.Spec.Source.Volume.Namespace
  • Optional value for GcpNfsVolumRestore.Spec.Destination.Volume.Namespace
  • ...

Related issue(s)
#585

@ravi-shankar-sap ravi-shankar-sap requested a review from a team as a code owner September 5, 2024 22:27
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 5, 2024
abalaie
abalaie approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@abalaie abalaie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 6, 2024
@kyma-bot kyma-bot merged commit f1ed036 into kyma-project:main Sep 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abalaie abalaie abalaie approved these changes

Assignees

@abalaie abalaie

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ravi-shankar-sap @abalaie @kyma-bot