Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AwsRedisInstance): make authEnabled mutable #589

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

dushanpantic
Copy link
Contributor

@dushanpantic dushanpantic commented Sep 6, 2024

Description

Changes proposed in this pull request:

  • makes authEnabled mutable

Required flow to disable auth on redis elasticache is described in AWS docs here: https://docs.aws.amazon.com/AmazonElastiCache/latest/red-ug/in-transit-encryption-disable.html

Related issue(s)
#580

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 6, 2024
@dushanpantic dushanpantic marked this pull request as ready for review September 9, 2024 07:10
@dushanpantic dushanpantic requested a review from a team as a code owner September 9, 2024 07:10
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2024
Copy link
Contributor

@ijovovic ijovovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 9, 2024
@kyma-bot kyma-bot merged commit 39246de into kyma-project:main Sep 9, 2024
11 checks passed
@dushanpantic dushanpantic deleted the aws-redis-mutable-auth branch September 9, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants