Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links detected by the Daily Markdown Link Check #837

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

mmitoraj
Copy link
Collaborator

Description

Changes proposed in this pull request:

Related issue(s)

@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 12, 2023
@@ -35,22 +35,18 @@ To see these settings, go to **Branches** in the left menu, under repository **S

![Branch protection rules](./assets/branch-protection-rules.png)

In Kyma, the protection rules are defined in the Prow [`config.yaml`](https://github.com/kyma-project/test-infra/blob/main/prow/config.yaml) file generated from rules defined in the [`prow-config.yaml`](https://github.com/kyma-project/test-infra/blob/main/templates/templates/prow-config.yaml) file and handled by a Prow component called [Branch Protector](https://github.com/kyma-project/test-infra/blob/main/docs/prow/prow-architecture.md#branch-protector).
In Kyma, the protection rules are defined in the Prow [`config.yaml`](https://github.com/kyma-project/test-infra/blob/main/prow/config.yaml) file generated from rules defined in the [`config.yaml`](https://github.com/kyma-project/test-infra/blob/main/prow/config.yaml) file and handled by a Prow component called [Branch Protector](https://github.com/kyma-project/test-infra/blob/main/docs/prow/prow-architecture.md#branch-protector).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you link to the same config.yaml file twice. Is this your intention?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, now it is the same file indeed. I will rephrase :)

@@ -4,4 +4,4 @@

This directory contains records of decisions made by the Core SIG and the Kyma project members before end of May 2019.

Currently, decisions are made based on issues or pull requests that have the decision flag assigned. The decision-making process is described [here](https://github.com/kyma-project/community/blob/main/governance.md).
Currently, decisions are made based on issues or pull requests that have the decision flag assigned. The decision-making process is described [here](https://github.com/kyma-project/community/blob/main/docs/governance/01-governance.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -79,7 +79,7 @@ See the following examples:
### Components
Currently, all images follow the proposed pattern and exclusions.

The following table assumes all tests will be renamed according to the naming convention proposed [here](https://github.com/kyma-project/community/blob/main/sigs-and-wgs/sig-core/proposals/test-folder-consolidation.md)
The following table assumes all tests will be renamed according to the naming convention proposed [here](https://github.com/kyma-project/community/blob/main/sigs-and-wgs/archive/sig-core/proposals/test-folder-consolidation.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The following table assumes all tests will be renamed according to the naming convention proposed [here](https://github.com/kyma-project/community/blob/main/sigs-and-wgs/archive/sig-core/proposals/test-folder-consolidation.md)
The following table assumes all tests will be renamed according to the naming convention proposed [here](https://github.com/kyma-project/community/blob/main/sigs-and-wgs/archive/sig-core/proposals/test-folder-consolidation.md).

@@ -22,7 +22,7 @@ The purpose of this Working Group (WG) is to build a Unified Demo Project with a

## Meetings

* [Thursday at 16:00 CEST](https://calendar.google.com/calendar/ical/3abtp9lh0mn3iiov5772jftccc%40group.calendar.google.com/public/basic.ics)
* Thursday at 16:00 CEST]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Thursday at 16:00 CEST]
* Thursday at 16:00 CEST

@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 13, 2023
@kyma-bot kyma-bot merged commit c7886ec into kyma-project:main Sep 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants