Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply markdowlint rules in the community repository #904

Merged
merged 10 commits into from
Mar 20, 2024
Merged

Apply markdowlint rules in the community repository #904

merged 10 commits into from
Mar 20, 2024

Conversation

grego952
Copy link
Contributor

@grego952 grego952 commented Mar 20, 2024

Description

Changes proposed in this pull request:

  • Apply markdowlint rules in the community repository

Related issue(s)
See also kyma-project/kyma#18497

@grego952 grego952 requested a review from a team as a code owner March 20, 2024 07:18
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 20, 2024
@Sawthis
Copy link
Contributor

Sawthis commented Mar 20, 2024

/override pre-community-presubmit-scanner

@kyma-bot
Copy link
Contributor

@Sawthis: Overrode contexts on behalf of Sawthis: pre-community-presubmit-scanner

In response to this:

/override pre-community-presubmit-scanner

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Comment on lines 172 to 175
```bash
git rebase HEAD~{number} -i # Enter the interactive mode to squash the number of commits. For example, to enter interactive mode and squash the last three commits:
git rebase HEAD~3 -i
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somehow the formatting breaks content below and treats it as code sample

Comment on lines +211 to 217
```bash
git checkout main # Switch to the main branch.
git pull # Update the main branch by pulling all changes.
git checkout {branch-name} # Switch back to your branch.
git rebase main # Reapply commits on the top of the main branch.
```

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the formatting is not ok

@@ -192,7 +195,7 @@ Here is the preferred terminology to use in the Kyma documentation:
| **the following** | **below**, **this**, **the described**, ... | or "as shown in the example" |
| **the previous**, **earlier** | **above**, **this**, **the described**, ... | or "as shown in the example" |

### Command line arguments
### Command line Arguments
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Command line Arguments
### Command Line Arguments

@kyma-bot
Copy link
Contributor

@grego952: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-community-presubmit-scanner 23a74cb link false /test pre-community-presubmit-scanner

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 20, 2024
@kyma-bot kyma-bot merged commit 65034b7 into kyma-project:main Mar 20, 2024
3 of 4 checks passed
@grego952 grego952 deleted the markdown-linting branch March 20, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants