Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Implement graceful shutdown #79

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

skhalash
Copy link
Contributor

@skhalash skhalash commented Oct 23, 2024

Description

Changes proposed in this pull request (what was done and why):

  • Implement graceful shutdown
  • Improve error handling - use errors and log them instead of panics
  • Improve logger creation
  • Fix docker warning

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@skhalash skhalash requested a review from a team as a code owner October 23, 2024 12:07
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 23, 2024
@skhalash skhalash added kind/bug Categorizes issue or PR as related to a bug. and removed cla: yes Indicates the PR's author has signed the CLA. labels Oct 23, 2024
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 23, 2024
@skhalash skhalash added area/quality Related to all activites around quality and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 23, 2024
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 23, 2024
@skhalash skhalash enabled auto-merge (squash) October 23, 2024 12:10
@skhalash skhalash merged commit 8ff5d6e into kyma-project:main Oct 23, 2024
39 of 44 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 23, 2024
@skhalash skhalash deleted the fix-shutdown branch October 24, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/quality Related to all activites around quality kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants