[WiP] Metrics PoC #191
Disper
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
Annotations
6 errors and 3 warnings
|
lint:
internal/controller/gardener_cluster_controller.go#L22
File is not `gci`-ed with --skip-generated -s standard -s default (gci)
|
|
lint:
internal/controller/gardener_cluster_controller.go#L26
File is not `gci`-ed with --skip-generated -s standard -s default (gci)
|
|
lint:
internal/controller/gardener_cluster_controller.go#L148
(*GardenerClusterController).resultWithoutRequeue - result 0 (sigs.k8s.io/controller-runtime/pkg/reconcile.Result) is always nil (unparam)
|
|
lint:
internal/controller/metrics/metrics.go#L19
internal/controller/metrics/metrics.go:19: Line contains TODO/BUG/FIXME: "TODO: test custom metric, remove when do..." (godox)
|
|
lint:
internal/controller/metrics/metrics.go#L27
metricGardenerClustersState is a global variable (gochecknoglobals)
|
|
lint
issues found
|
|
lint:
internal/controller/metrics/metrics.go#L12
var-naming: const globalAccountId should be globalAccountID (revive)
|
|
lint:
internal/controller/metrics/metrics.go#L13
var-naming: const runtimeId should be runtimeID (revive)
|
|
lint:
internal/controller/metrics/metrics.go#L20
var-naming: don't use underscores in Go names; var playground_totalReconciliationLoopsStarted should be playgroundTotalReconciliationLoopsStarted (revive)
|