Implement backup and restore for Cluster Role Bindings and OIDC #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
akgalwas
changed the title
akgalwas
changed the title
akgalwas
changed the title
akgalwas
changed the title
koala7659
reviewed
Jan 7, 2025
| @@ -96,6 +98,8 @@ func NewRestoreConfig() RestoreConfig { | |||
| flag.StringVar(&restoreConfig.InputType, "input-type", InputTypeJSON, "Type of input to be used. Possible values: **txt** (see the example hack/runtime-migrator/input/runtimeids_sample.txt), and **json** (see the example hack/runtime-migrator/input/runtimeids_sample.json).") | |||
| flag.StringVar(&restoreConfig.InputFilePath, "input-file-path", "/path/to/input/file", "Path to the input file containing RuntimeCRs to be migrated.") | |||
| flag.StringVar(&restoreConfig.BackupDir, "backup-path", "/path/to/backup/dir", "Path to the directory containing backup.") | |||
| flag.BoolVar(&restoreConfig.RestoreCRB, "restore-crbs", true, "Flag determining whether CRBs should be restored") | |||
| flag.BoolVar(&restoreConfig.RestoreOIDC, "restore-oidcs", true, "Flag determining whether OIDCs should be restored") | |||
There was a problem hiding this comment.
Pls add new flags to func PrintRestoreConfig(cfg RestoreConfig) function
| } | ||
|
|
||
| resultsFile, err := r.outputWriter.SaveRestoreResults(r.results) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| slog.Info(fmt.Sprintf("Restore completed. Successfully restored backups: %d, Failed operations: %d", r.results.Succeeded, r.results.Failed)) | ||
| slog.Info(fmt.Sprintf("Restore completed. Successfully restored backups: %d, Failed operations: %d, Skipped backups: %d, ", r.results.Succeeded, r.results.Failed, r.results.Skipped)) |
There was a problem hiding this comment.
Please also align report for the number of skipped backups with backup.go file. Currently in dry-run mode skipped backups are not reported correctly.
2025/01/07 18:08:18 INFO Backup completed. Successfully stored backups: 0, Failed backups: 0
koala7659
reviewed
Jan 7, 2025
| @@ -86,14 +89,28 @@ func (r Restore) Do(ctx context.Context, runtimeIDs []string) error { | |||
| continue | |||
| } | |||
|
|
|||
| if currentShoot.Generation == objectsToRestore.OriginalShoot.Generation { | |||
There was a problem hiding this comment.
I'm not convinced if we should have this condition to skip restore process. What about restoring possibly deleted or broken CRBs? Those objects are are not related with shoot generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#557