Extending Runtime Custom Resource with Additional Workers #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
kyma-bot
added
the
do-not-merge/work-in-progress
kyma-bot
added
size/XXL
kyma-bot
removed
the
do-not-merge/work-in-progress
m00g3n
reviewed
Jan 24, 2025
| var controlPlaneConf, infraConfig *runtime.RawExtension | ||
| zones := getZones(rt.Spec.Shoot.Provider.Workers) | ||
| infraConfig, controlPlaneConf, err = getConfig(rt.Spec.Shoot, zones) | ||
| if len(rt.Spec.Shoot.Provider.Workers) != 1 { |
There was a problem hiding this comment.
NOTE: we can have this code moved to validation webhook later on
| infraConfig, controlPlaneConf, err = getConfig(rt.Spec.Shoot, zones) | ||
| if err != nil { | ||
| return err | ||
| if len(rt.Spec.Shoot.Provider.Workers) != 1 { |
There was a problem hiding this comment.
NOTE: we can have this code moved to validation webhook later on
Comment on lines
+254
to
+266
| // uncomment if we decide to require to validate to have all same zones in all workers | ||
| // | ||
| //if len(workers) == 1 { | ||
| // return zones, nil | ||
| //} | ||
| // | ||
| //for _, worker := range workers { | ||
| // if !slices.Equal(worker.Zones, zones) { | ||
| // return nil, errors.New("workers have specified different zones set, or zones are in different order") | ||
| // } | ||
| //} | ||
|
|
||
| return zones, nil |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to define and modify multiple workers for a Gardener shoot in the additionalWorkers collection
Description:
Changes proposed in this pull request:
additionalWorkerscollection - it will allow to define more worker groups in Gardener Shoot for Kyma RuntimeNewProviderExtenderPatchOperationto patch Zones and version information for each Worker separately.InfrastructureConfigandControlPlaneConfigare treated as immutable during update unless they are specified in the RuntimeCRLogic flow operation update:
On shoot create:
additionalWorkerscollectionInfrastructureConfigandcontrolPlaneConfigare created to include ALL zones used in ALL provided workers .controlPlaneConfigare provided inRuntimeCRthey will be used to create ShootinfrastructureConfigzones cannot match with worker zones - the operation will failOn shoot update:
additionalWorkerscollection. This operation will not affect existinginfrastructureConfigandcontrolPlaneConfigInfrastructureConfigandControlPlaneConfigshoot data are immutableinfrastructureConfiginfrastructureConfigandcontrolPlaneConfigare provided inRuntimeCRthey will be used to create ShootinfrastructureConfigzones cannot match with worker zones - the operation will failAdditional:
Related issue(s)
#46