Skip to content

Commit

Permalink
adjust messages
Browse files Browse the repository at this point in the history
  • Loading branch information
nataliasitko committed Jan 29, 2025
1 parent 367b787 commit 16b62b6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
After the Istio module's update, the Istio custom resource (CR) is in the `Warning` sate, and mesh connectivity is disrupted. When you click on the warning in Kyma dashboard or run `kubectl get istio default -n kyma-system -o jsonpath='{.status.description}'`, you get the message:

```
Some Pods with Istio sidecar injection failed to restart. See kyma-system/istio-controller-manager logs to learn more about the warning: Istio Controller could not restart one or more Istio-injected Pods.`
Some Pods with Istio sidecar injection failed to restart. To learn more about the warning, see kyma-system/istio-controller-manager logs: Istio Controller could not restart one or more Istio-injected Pods.`
```

## Cause
Expand Down
2 changes: 1 addition & 1 deletion internal/restarter/sidecars.go
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ func (s *SidecarsRestarter) Restart(ctx context.Context, istioCR *v1alpha2.Istio
if warningsCount-len(pods) > 0 {
warningMessage += fmt.Sprintf(" and %d additional workload(s)", warningsCount-len(pods))
}
warningErr := described_errors.NewDescribedError(errors.New("Istio Controller could not restart one or more Istio-injected Pods."), "Some Pods with Istio sidecar injection failed to restart. To learn more about the warning, see kyma-system/istio-controller-manager logs.").SetWarning()
warningErr := described_errors.NewDescribedError(errors.New("Istio Controller could not restart one or more Istio-injected Pods."), "Some Pods with Istio sidecar injection failed to restart. To learn more about the warning, see kyma-system/istio-controller-manager logs").SetWarning()
s.StatusHandler.SetCondition(istioCR, v1alpha2.NewReasonWithMessage(v1alpha2.ConditionReasonProxySidecarManualRestartRequired, warningMessage))
s.Log.Info(warningMessage)
return warningErr, false
Expand Down

0 comments on commit 16b62b6

Please sign in to comment.