-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cleanup mechanism for conversation history #369
Conversation
Note(s) for PR Auther:
Note(s) for PR Reviewer(s):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job, it looks good.
Can you please add integration tests? You can use fakeredis for that.
You can just assert in the test if a key is deleted after certain seconds, by faking REDIS_TTL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 👍🏼
Description
Changes proposed in this pull request:
Related issue(s)
#283