-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove avs #1182
Merged
Merged
Remove avs #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add one of following labels |
kyma-bot
added
the
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
label
Sep 24, 2024
piotrmiskiewicz
force-pushed
the
remove-avs
branch
from
September 24, 2024 14:03
f4141b2
to
bdcdd93
Compare
/hold |
kyma-bot
added
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Sep 24, 2024
jaroslaw-pieszka
previously approved these changes
Sep 25, 2024
jaroslaw-pieszka
previously approved these changes
Sep 25, 2024
/unhold |
kyma-bot
removed
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Sep 25, 2024
ebensom
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jaroslaw-pieszka
added
the
kind/enhancement
Categorizes issue or PR as related to modifying or improving an existing feature
label
Sep 25, 2024
jaroslaw-pieszka
approved these changes
Sep 25, 2024
ukff
pushed a commit
to ukff/kyma-environment-broker
that referenced
this pull request
Oct 9, 2024
* Remove AvS code * wip * wip * wip * wip * wip * wip
kyma-gopher-bot
added a commit
that referenced
this pull request
Oct 9, 2024
* wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * Kyma Binding with Gardener's Adminkubeconfig (#1160) * Gardener Admin Kubeconfig Generation as a Default Binding Provider * Linter & Default Service Account Correction * Build Correction * Added Missing Scheme Registration for shoot Package * Linter * Removed Empty Test * Removed Debug Lines * Review Remarks * Review Remarks * Removed Unnecessary Import * Linter * Review Remarks * Review Remarks * Linter * Review Remarks * Bump sec-scanners-config.yaml, KEB images and Chart to 1.10.6 (#1181) * Extend binding create endpoint (#1180) * Extend binding create endpoint * Apply suggestions * Remove necessary comment * Bump sec-scanners-config.yaml, KEB images and Chart to 1.10.7 (#1183) * Remove avs (#1182) * Remove AvS code * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip --------- Co-authored-by: Wojciech Wrzalik <[email protected]> Co-authored-by: Kyma gopher bot <[email protected]> Co-authored-by: KsaweryZietara <[email protected]> Co-authored-by: Piotr Miśkiewicz <[email protected]>
kyma-gopher-bot
added a commit
that referenced
this pull request
Oct 9, 2024
* wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * Kyma Binding with Gardener's Adminkubeconfig (#1160) * Gardener Admin Kubeconfig Generation as a Default Binding Provider * Linter & Default Service Account Correction * Build Correction * Added Missing Scheme Registration for shoot Package * Linter * Removed Empty Test * Removed Debug Lines * Review Remarks * Review Remarks * Removed Unnecessary Import * Linter * Review Remarks * Review Remarks * Linter * Review Remarks * Bump sec-scanners-config.yaml, KEB images and Chart to 1.10.6 (#1181) * Extend binding create endpoint (#1180) * Extend binding create endpoint * Apply suggestions * Remove necessary comment * Bump sec-scanners-config.yaml, KEB images and Chart to 1.10.7 (#1183) * Remove avs (#1182) * Remove AvS code * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip --------- Co-authored-by: Wojciech Wrzalik <[email protected]> Co-authored-by: Kyma gopher bot <[email protected]> Co-authored-by: KsaweryZietara <[email protected]> Co-authored-by: Piotr Miśkiewicz <[email protected]>
kyma-gopher-bot
added a commit
that referenced
this pull request
Oct 9, 2024
* wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * Kyma Binding with Gardener's Adminkubeconfig (#1160) * Gardener Admin Kubeconfig Generation as a Default Binding Provider * Linter & Default Service Account Correction * Build Correction * Added Missing Scheme Registration for shoot Package * Linter * Removed Empty Test * Removed Debug Lines * Review Remarks * Review Remarks * Removed Unnecessary Import * Linter * Review Remarks * Review Remarks * Linter * Review Remarks * Bump sec-scanners-config.yaml, KEB images and Chart to 1.10.6 (#1181) * Extend binding create endpoint (#1180) * Extend binding create endpoint * Apply suggestions * Remove necessary comment * Bump sec-scanners-config.yaml, KEB images and Chart to 1.10.7 (#1183) * Remove avs (#1182) * Remove AvS code * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip --------- Co-authored-by: Wojciech Wrzalik <[email protected]> Co-authored-by: Kyma gopher bot <[email protected]> Co-authored-by: KsaweryZietara <[email protected]> Co-authored-by: Piotr Miśkiewicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla: yes
Indicates the PR's author has signed the CLA.
kind/enhancement
Categorizes issue or PR as related to modifying or improving an existing feature
lgtm
Looks good to me!
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)